Skip to content

Conversation

@SpadeA-Tang
Copy link
Contributor

@SpadeA-Tang SpadeA-Tang commented Oct 22, 2025

issue: #45001
ref: #42148

Signed-off-by: SpadeA <[email protected]>
@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo October 22, 2025 11:36
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 22, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 22, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

Signed-off-by: SpadeA <[email protected]>
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.93%. Comparing base (cab9ee6) to head (1abc84a).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/alter_collection_task.go 0.00% 16 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (76.93%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45041      +/-   ##
==========================================
+ Coverage   74.35%   76.93%   +2.58%     
==========================================
  Files        1331     1838     +507     
  Lines      207555   285520   +77965     
==========================================
+ Hits       154318   219657   +65339     
- Misses      46033    58651   +12618     
- Partials     7204     7212       +8     
Components Coverage Δ
Client 78.03% <ø> (ø)
Core 83.88% <ø> (∅)
Go 75.03% <0.00%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
internal/rootcoord/alter_collection_task.go 80.24% <0.00%> (-4.45%) ⬇️

... and 530 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SpadeA-Tang, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SpadeA-Tang
Copy link
Contributor Author

/ci-rerun-ut-go

2 similar comments
@SpadeA-Tang
Copy link
Contributor Author

/ci-rerun-ut-go

@SpadeA-Tang
Copy link
Contributor Author

/ci-rerun-ut-go

@mergify mergify bot added the ci-passed label Oct 23, 2025
@zhagnlu
Copy link
Contributor

zhagnlu commented Oct 24, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 17ab2ac into milvus-io:master Oct 24, 2025
14 of 18 checks passed
sre-ci-robot pushed a commit that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants