Skip to content

fix: fix alter collection failed for STRUCT sub-fields [2.6] #45042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2025
Merged

fix: fix alter collection failed for STRUCT sub-fields [2.6] #45042

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5ba769
fix done
SpadeA-Tang Oct 22, 2025
4f0a81c
more error msg
SpadeA-Tang Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions internal/rootcoord/alter_collection_task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,17 @@ func ResetFieldProperties(coll *model.Collection, fieldName string, newProps []*
return nil
}
}
for _, structField := range coll.StructArrayFields {
if structField.Name == fieldName {
return merr.WrapErrParameterInvalidMsg("struct field has no properties to alter", fieldName)
}
for i, field := range structField.Fields {
if field.Name == fieldName {
structField.Fields[i].TypeParams = newProps
return nil
}
}
}
return merr.WrapErrParameterInvalidMsg("field %s does not exist in collection", fieldName)
}

Expand All @@ -397,6 +408,16 @@ func GetFieldProperties(coll *model.Collection, fieldName string) ([]*commonpb.K
return field.TypeParams, nil
}
}
for _, structField := range coll.StructArrayFields {
if structField.Name == fieldName {
return nil, merr.WrapErrParameterInvalidMsg("struct field has no properties", fieldName)
}
for _, field := range structField.Fields {
if field.Name == fieldName {
return field.TypeParams, nil
}
}
}
return nil, merr.WrapErrParameterInvalidMsg("field %s does not exist in collection", fieldName)
}

Expand Down
Loading