-
Notifications
You must be signed in to change notification settings - Fork 58
Investigate potential upgrades #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
First stage is done as of right now: upgrade everything. There is a bug in https://github.com/minio/minio-py (temporarily patched so tests pass). I'll address it separately. Next stage: adding additional coverage, for which I have a rather large checklist to go through. |
|
|
|
We are able to release with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses library and SDK upgrades across the repository, replacing deprecated AWS SDK Go v1 and Java v1 with their v2 counterparts ahead of their EOL dates (July 2025 and December 2025 respectively). The changes also include system-level upgrades to Ubuntu 24.04, Node.js 24, Java 21, .NET 8.0, and Python 3.12.
- Migration from AWS SDK Go v1 to v2 and AWS SDK Java v1 to v2
- System environment upgrades (Ubuntu 24.04, Node.js 24, JDK 21, .NET 8.0, Python 3.12)
- Updated build configurations and dependency management for Python packages with
--break-system-packagesflag - Added new testing functionality for bucket versioning
Reviewed Changes
Copilot reviewed 52 out of 57 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| source.sh | Updates Go version to 1.25.4 and Gradle to 9.2.0 |
| Dockerfile | Upgrades base image from Ubuntu 22.04 to 24.04 |
| run/core/aws-sdk-go-v2/main.go | New AWS SDK Go v2 implementation with comprehensive S3 tests |
| run/core/aws-sdk-go/main.go | Removed AWS SDK Go v1 implementation |
| run/core/minio-go/versioning_test.go | Added versioning test for excluded prefixes |
| build/versioning/*.go | Migrated from AWS SDK Go v1 to v2 API |
| install-packages.list | Updated Java and .NET package versions |
| preinstall.sh | Updated Node.js to v24 and Python to 3.12 |
| build/awscli/install.sh | Updated botocore and AWS CLI versions with new empty body handling |
| build/minio-py/install.sh | Added --break-system-packages flag for PEP 668 compliance |
| run/core/s3select/*.py | Updated Minio Python SDK calls to use keyword arguments |
| run/core/aws-sdk-php/*.php | Migrated from Psr7\stream_for() to Psr7\Utils::streamFor() |
Comments suppressed due to low confidence (6)
build/versioning/get.go:168
result.Body.Close()
build/versioning/stat.go:161
- result may be nil at this dereference because err may not have been checked.
build/versioning/stat.go:166 - result may be nil at this dereference because err may not have been checked.
build/versioning/stat.go:186 - result may be nil at this dereference because err may not have been checked.
build/versioning/stat.go:186 - result may be nil at this dereference because err may not have been checked.
build/versioning/stat.go:191 - result may be nil at this dereference because err may not have been checked.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@harshavardhana This one is ready, everything works just fine (including EOS). |
Addressing upgrades issue.
Updated most of the libs (if not all) in the repo.
Deprecations as follows:
☝️ They are getting removed. V2 on both will be used instead.
Added extra testing functionality.