Assign urls to edx contentfiles when possible #2420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbertrand
added
Work in Progress
Needs Review
shanbady
approved these changes
Aug 8, 2025
|
|
||
|
|
||
| # Base content URLs for different sources | ||
| CONTENT_BASE_URL_MITXONLINE = get_string( |
There was a problem hiding this comment.
will these values also work fine for rc? (do we need an associated PR in ol-infrastructure?)
There was a problem hiding this comment.
Good question, the xpro, mitxonline, and oll buckets and their corresponding api urls in RC are all pointing to production. But for mit_edx, the urls point to production and the bucket is a qa bucket. Maybe there's no real difference between the buckets but this seems like a bug on the ol-infrastructure side, so I'll make a PR to fix that.
There was a problem hiding this comment.
shanbady
added
Waiting on author
and removed
Needs Review
mbertrand
force-pushed
the
mb/edx_cf_urls
branch
from
e8c026e to
e310267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Related to https://github.com/mitodl/hq/issues/7989
Description (What does it do?)
How can this be tested?
Find a course from each of the following sources and ingest the contentfiles for it: mit_edx, mitxonline, xpro, oll:
./manage.py backpopulate_<etl_source>_files --resource-ids <course_id> --overwriteIt should complete without errors, and the majority of contentfiles should then have urls. Try out a bunch of links to make sure they work, including urls that contain
assetand urls that containblockAlso run
./manage.py backpopulate_canvas_courses --canvas-ids <course_readable_id> --overwriteto make sure that still works normally.For mit_edx, mitxonline and xpro courses, you may be redirected to a "You must be enrolled in this course" page for these links if you are not logged in, or logged in as someone other than a superuser.