hack: use bake to build buildkit images #6107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2025
crazy-max
commented
Aug 14, 2025
crazy-max
force-pushed
the
bake-images
branch
2 times, most recently
from
8993f77 to
e76584a
Compare
crazy-max
commented
Aug 14, 2025
| name: Build | ||
| uses: docker/bake-action@v6 | ||
| with: | ||
| source: ${{ github.server_url }}/${{ github.repository }}.git#${{ github.ref }} |
There was a problem hiding this comment.
Can't use Git context from our actions-toolkit: https://github.com/docker/actions-toolkit/blob/633bcf1936ffff0e05a4bbe2b23c71abf6f4111e/src/context.ts#L45-L60
Because currently it fetches by sha and not git ref so tags are not pulled: https://github.com/crazy-max/buildkit/actions/runs/16967780276/job/48096258733#step:7:440. That would therefore set a commit sha as BuildKit version: https://github.com/crazy-max/buildkit/actions/runs/16967780276/job/48096258733#step:7:1654
docker/actions-toolkit#677 would fix it but it's probably better to wait for #5974.
So in the meantime set Git context manually with full git ref as we currently do in our hack script:
Line 43 in ec7a152
crazy-max
force-pushed
the
bake-images
branch
2 times, most recently
from
2c7f587 to
a20221c
Compare
crazy-max
force-pushed
the
bake-images
branch
from
ec17dd5 to
89e4915
Compare
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
bake-images
branch
from
89e4915 to
1fa57ee
Compare
tonistiigi
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue carrying changes from #3204