LG-5656: Remove support for refEl property #3270
Merged
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c0c7637 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for the refEl property from the Select component to enforce proper reference handling by always using the internal MenuButton instance. This is a breaking change that simplifies the API by removing a potentially confusing prop.
Key changes:
- Excludes
refElfrom inherited PopoverProps in Select component types - Updates import statements to use named imports instead of default imports
- Documents the breaking change in a changeset
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/select/src/Select/Select.types.ts | Adds 'refEl' to the omitted PopoverProps to prevent external ref override |
| packages/select/src/MenuButton/MenuButton.tsx | Updates Button import from default to named import |
| packages/select/src/ListMenu/ListMenu.tsx | Updates Popover import from default to named imports |
| .changeset/clean-news-lay.md | Documents the breaking change for release notes |
|
Size Change: -4 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
stephl3
reviewed
Oct 30, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@leafygreen-ui/select': major | |||
There was a problem hiding this comment.
dang I wish this wasn't a major but I guess it has to be 🥲
There was a problem hiding this comment.
updated the language RFAL?
.changeset/clean-news-lay.md
Outdated
| '@leafygreen-ui/select': major | ||
| --- | ||
|
|
||
| Removes support for `refEl` property, which should always be referencing the `MenuButton` instance defined in the `Select` component |
There was a problem hiding this comment.
Can we update this language that it's addressing a bug and that refEl was never doing anything anyways?
|
Coverage after merging brooke/select-mod into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
stephl3
approved these changes
Oct 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-5656
✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes