Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clean-news-lay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@leafygreen-ui/select': major
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang I wish this wasn't a major but I guess it has to be 🥲

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the language RFAL?

---

Removes support for `refEl` property, which was never leveraged within the component logic. Instead, the `refEl` property always positions the internal MenuButton component against the internal ListBox component. There are no end user changes, just a more precise `SelectProps` type definition.
2 changes: 1 addition & 1 deletion packages/select/src/ListMenu/ListMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import isUndefined from 'lodash/isUndefined';
import { css, cx } from '@leafygreen-ui/emotion';
import { useAvailableSpace } from '@leafygreen-ui/hooks';
import { useDarkMode } from '@leafygreen-ui/leafygreen-provider';
import Popover, { Align, Justify } from '@leafygreen-ui/popover';
import { Align, Justify, Popover } from '@leafygreen-ui/popover';

import { DropdownWidthBasis } from '../Select/Select.types';
import SelectContext from '../SelectContext';
Expand Down
2 changes: 1 addition & 1 deletion packages/select/src/MenuButton/MenuButton.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { useCallback, useContext } from 'react';

import Button, { Size as ButtonSize, Variant } from '@leafygreen-ui/button';
import { Button, Size as ButtonSize, Variant } from '@leafygreen-ui/button';
import { css, cx } from '@leafygreen-ui/emotion';
import CaretDownIcon from '@leafygreen-ui/icon/dist/CaretDown';
import { useDarkMode } from '@leafygreen-ui/leafygreen-provider';
Expand Down
5 changes: 4 additions & 1 deletion packages/select/src/Select/Select.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ export type DropdownWidthBasis =

export interface BaseSelectProps
extends Omit<React.ComponentProps<'button'>, 'onChange' | 'onClick'>,
Omit<PopoverProps, 'active' | 'dismissMode' | 'onToggle' | 'spacing'>,
Omit<
PopoverProps,
'active' | 'dismissMode' | 'onToggle' | 'spacing' | 'refEl'
>,
DarkModeProps,
LgIdProps {
/**
Expand Down
Loading