fix(@netlify/vite-plugin-react-router): fix local dev with edge: true
#572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remix-edge ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for remix-serverless ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
serhalp
changed the title
edge: trueedge: true
serhalp
changed the title
edge: trueedge: true
serhalp
force-pushed
the
fix/edge-dev-entry
branch
2 times, most recently
from
c0c34b0 to
4bb55b6
Compare
serhalp
commented
Nov 5, 2025
Comment on lines
61
to
62
| "@netlify/edge-functions": "^3.0.2", | ||
| "@netlify/functions": "^5.1.0", |
Member
Author
There was a problem hiding this comment.
Not completely related, but these shouldn't be dev deps anymore, since they're needed for the netlifyRouterContext export added in 2.0.0.
serhalp
force-pushed
the
fix/edge-dev-entry
branch
from
4bb55b6 to
f255a7d
Compare
because why not
These are now needed at runtime when importing `netlifyRouterContext`.
There's some more sophisticated solution involving the Vite Environment API down the line, but for now I just ported something very similar to what we do for Remix: have users write a one-liner server entry to uses our Vite virtual module that conditionally resolves depending on build (edge entry) vs. dev (node.js entry). As a bonus, the file for users to copy is a single line instead of 40.
serhalp
force-pushed
the
fix/edge-dev-entry
branch
from
f255a7d to
018f127
Compare
pieh
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #562. It turns out
react-router devdoes not work with the new edge mode as documented. This is because React Router uses the user's server entry file, which is intentionally intended for an edge runtime, and unfortunately incompatible with a Node.js runtime, which it uses in dev.There's some more sophisticated solution involving the Vite Environment API we can look into down the line, but for now I just ported something very similar to what we do for Remix: have users write a one-liner server entry that uses our Vite virtual module that conditionally resolves depending on build (edge entry) vs. dev (node.js entry).
As a bonus, the file for users to copy is a single line instead of 40 🎉.