Skip to content

chore: use std::make_unique to improve memory management - #9162

Merged
Rello merged 2 commits into
masterfrom
bugfix/avoidMemoryLeakOfQTranslator
Feb 12, 2026
Merged

chore: use std::make_unique to improve memory management#9162
Rello merged 2 commits into
masterfrom
bugfix/avoidMemoryLeakOfQTranslator

Conversation

@mgallien

@mgallien mgallien commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

setting the parent on a QObject will make sure that when parent is deleted the child objects will be too

@mgallien mgallien added this to the 4.1.0 milestone Dec 1, 2025
@sonarqubecloud

sonarqubecloud Bot commented Dec 1, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)
D Maintainability Rating on New Code (required ≥ A)
17 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien
chore: use std::make_unique to improve memory management
3712a8b 
setting the parent on a QObject will make sure that when parent is
deleted the child objects will be too

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
mgallien force-pushed the bugfix/avoidMemoryLeakOfQTranslator branch from 7248a15 to 3712a8b Compare February 6, 2026 08:42
@github-actions

github-actions Bot commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-9162.zip

Digest: sha256:537b960d8b12b522706d8245274cad96cb41da33c001c2d50a30c442c703d8e9

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

sonarqubecloud Bot commented Feb 12, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)
D Maintainability Rating on New Code (required ≥ A)
16 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Rello
Rello merged commit 8f53ebb into master Feb 12, 2026
23 of 24 checks passed
@Rello
Rello deleted the bugfix/avoidMemoryLeakOfQTranslator branch February 12, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding approved these changes
@i2h3 i2h3 i2h3 approved these changes
@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio
@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

Assignees

No one assigned

Labels

4. to release

Projects

None yet

Milestone

33.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mgallien @nilsding @i2h3 @Rello