Skip to content

chore: use std::make_unique to improve memory management #9162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rello merged 2 commits into from
Feb 12, 2026
Merged

chore: use std::make_unique to improve memory management #9162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3712a8b
chore: use std::make_unique to improve memory management
mgallien Dec 1, 2025
ae70285
Merge branch 'master' into bugfix/avoidMemoryLeakOfQTranslator
Rello Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions src/gui/application.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,9 +1009,9 @@ QString enforcedLanguage()

void Application::setupTranslations()
{
auto *translator = new QTranslator(this);
auto *qtTranslator = new QTranslator(this);
auto *qtkeychainTranslator = new QTranslator(this);
auto translator = std::make_unique<QTranslator>();
auto qtTranslator = std::make_unique<QTranslator>();
auto qtkeychainTranslator = std::make_unique<QTranslator>();

const auto trPath = applicationTrPath();
const auto trFolder = QDir{trPath};
Expand Down Expand Up @@ -1064,12 +1064,20 @@ void Application::setupTranslations()
qCDebug(lcApplication()) << "impossible to load QtKeychain translation catalog" << qtkeychainTrFile;
}
}
if (!translator->isEmpty())
installTranslator(translator);
if (!qtTranslator->isEmpty())
installTranslator(qtTranslator);
if (!qtkeychainTranslator->isEmpty())
installTranslator(qtkeychainTranslator);
if (!translator->isEmpty()) {
translator->setParent(this);
installTranslator(translator.release());
}

if (!qtTranslator->isEmpty()) {
qtTranslator->setParent(this);
installTranslator(qtTranslator.release());
}

if (!qtkeychainTranslator->isEmpty()) {
qtkeychainTranslator->setParent(this);
installTranslator(qtkeychainTranslator.release());
}
} else {
qCWarning(lcApplication()) << "translation catalog failed to load";
const auto folderContent = trFolder.entryList();
Expand Down
Loading