-
Notifications
You must be signed in to change notification settings - Fork 935
Multiqc2topics #9271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiqc2topics #9271
Conversation
modules/nf-core/multiqc/main.nf
Outdated
| path "*_data" , emit: data | ||
| path "*_plots" , optional:true, emit: plots | ||
| path "versions.yml" , emit: versions | ||
| tuple val("${task.process}"), val('multiqc'), eval('multiqc --version | sed -e "s/multiqc, version //g"'), emit: versions_multiqc, topic: 'versions' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try this:
| tuple val("${task.process}"), val('multiqc'), eval('multiqc --version | sed -e "s/multiqc, version //g"'), emit: versions_multiqc, topic: 'versions' | |
| tuple val("${task.process}"), val('multiqc'), eval('multiqc --version | sed "s/.* //g"'), emit: versions_multiqc, topic: 'versions' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your version worked as well, so I changed it to that!
mapo9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
modules/nf-core/multiqc/main.nf
Outdated
| path "*_data" , emit: data | ||
| path "*_plots" , optional:true, emit: plots | ||
| path "versions.yml" , emit: versions | ||
| tuple val("${task.process}"), val('multiqc'), eval('multiqc --version | sed -e "s/multiqc, version //g"'), emit: versions_multiqc, topic: 'versions' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we all did topic: xy, emit: yx
maybe good to stay consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also harshil alignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed!
PR checklist
Closes #9259
This implements the new topics approach for catching tool versions in a module
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda