chore: add skew-version support in Cloudflare open-next worker #7980

dario-piotrowicz · 2025-07-14T23:33:48Z

Description

This PR adds support for skew protection in the Cloudflare open-next deployment (which has been recently added to the open-next adapter (in 1.5.0))

For more details on the feature see: https://opennext.js.org/cloudflare/howtos/skew

Validation

I've applied the changes and deployed the site: https://nodejs-org.testing.devprod.cloudflare.dev/en
And everything seems to be working as expected 🙂

I'll double check with @vicb if he has some suggestion to best test that the skew protection is actually in place and working as expected 🙂

Related Issues

Check List

I have read the Contributing Guidelines and made commit messages that follow the guideline.
I have run pnpm format to ensure the code follows the style guide.
I have run pnpm test to check if all tests are passing.
I have run pnpm build to check if the website builds without errors.
I've covered new added functionality with unit tests if necessary.

vercel · 2025-07-14T23:33:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Jul 25, 2025 1:53pm

codecov · 2025-07-14T23:34:57Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.01%. Comparing base (230c564) to head (3e2e029).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
packages/rehype-shiki/src/index.mjs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7980      +/-   ##
==========================================
+ Coverage   72.95%   73.01%   +0.06%     
==========================================
  Files          95       95              
  Lines        8317     8317              
  Branches      215      214       -1     
==========================================
+ Hits         6068     6073       +5     
+ Misses       2248     2243       -5     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dario-piotrowicz · 2025-07-14T23:53:57Z

https://github.com/nodejs/nodejs.org/actions/runs/16280236085/job/45968187377?pr=7980#step:11:74 👀

again! is this something that is happening quite often? 😓

apps/site/next.config.mjs

apps/site/package.json

avivkeller · 2025-07-15T00:02:52Z

https://github.com/nodejs/nodejs.org/actions/runs/16280236085/job/45968187377?pr=7980#step:11:74 👀

again! is this something that is happening quite often? 😓

Yea, it happens pretty often now that I think about it.

https://github.com/nodejs/nodejs.org/actions/workflows/playwright-cloudflare-open-next.yml?query=is%3Afailure

dario-piotrowicz · 2025-07-15T00:09:37Z

https://github.com/nodejs/nodejs.org/actions/runs/16280236085/job/45968187377?pr=7980#step:11:74 👀
again! is this something that is happening quite often? 😓

Yea, it happens pretty often now that I think about it.

https://github.com/nodejs/nodejs.org/actions/workflows/playwright-cloudflare-open-next.yml?query=is%3Afailure

oof... and do you know if it is just happening on the open-next build?

apps/site/wrangler.jsonc

avivkeller · 2025-07-15T12:18:07Z

oof... and do you know if it is just happening on the open-next build?

yes, it's not duplicated on the regular Playwright run. We've had no¹ failures on that.

Excluding changes that you would expect to break Playwright. ↩

dario-piotrowicz · 2025-07-15T12:33:50Z

oof... and do you know if it is just happening on the open-next build?

yes, it's not duplicated on the regular Playwright run. We've had no1 failures on that.

Footnotes

Excluding changes that you would expect to break Playwright. ↩

ok, so sorry for the inconvenience 🙇 I'll look into addressing the issue then 🙇

avivkeller · 2025-07-15T12:50:05Z

No problem! It's not a required check so it's not breaking anything

dario-piotrowicz · 2025-07-15T12:58:18Z

No problem! It's not a required check so it's not breaking anything

good! but it must be pretty annoying 😅😓

AugustinMauroy

LGMT !

ovflowd

LGTM! Buit can we document this variable for the time being somewhere? (the OPEN_NEXT_CLOUDFLARE)

ovflowd · 2025-07-16T13:06:10Z

LGMT !

Every time you write LGMT I feel like I want to eat Subway's BLT for some reason

avivkeller · 2025-07-16T14:02:18Z

LGMT !

Every time you write LGMT I feel like I want to eat Subway's BLT for some reason

Looks good, me too!

avivkeller · 2025-07-24T17:49:46Z

Yeah, no problem

dario-piotrowicz · 2025-07-25T10:53:08Z

#8023 🙂

github-actions · 2025-07-25T11:18:08Z

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟠 82	🟢 100	🟢 100	🟢 100	🔗
/en/about	🟢 100	🟢 97	🟢 100	🟠 88	🔗
/en/about/previous-releases	🟢 99	🟢 93	🟢 100	🟠 89	🔗
/en/download	🟠 87	🟢 100	🟢 100	🟢 100	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 100	🔗

ovflowd · 2025-07-25T13:30:38Z

@dario-piotrowicz builds seems to be failing tho

dario-piotrowicz · 2025-07-25T13:54:10Z

@dario-piotrowicz builds seems to be failing tho

Thanks 🙂

Yeah I noticed, for some reason the build script is not detecting the open-next package, I don't really understand why 😕

I've fixed it in this way: 3e2e029

Not the best solution possible but I think it should be good enough for now and we can always dig deeper into the issue if/when needed? what do you think? 🙂

PS: I couldn't reproduce the issue locally 😕

vercel bot deployed to Preview July 14, 2025 23:35 View deployment

avivkeller reviewed Jul 14, 2025

View reviewed changes

apps/site/next.config.mjs Outdated Show resolved Hide resolved

avivkeller reviewed Jul 14, 2025

View reviewed changes

apps/site/package.json Outdated Show resolved Hide resolved

vicb reviewed Jul 15, 2025

View reviewed changes

apps/site/wrangler.jsonc Outdated Show resolved Hide resolved

vercel bot deployed to Preview July 15, 2025 09:14 View deployment

dario-piotrowicz force-pushed the dario/open-next-skew-protection branch from 3f20cb6 to 9256c7a Compare July 15, 2025 22:05

vercel bot deployed to Preview July 15, 2025 22:07 View deployment

dario-piotrowicz marked this pull request as ready for review July 15, 2025 22:11

dario-piotrowicz requested review from a team as code owners July 15, 2025 22:11

flakey5 approved these changes Jul 15, 2025

View reviewed changes

araujogui approved these changes Jul 16, 2025

View reviewed changes

AugustinMauroy approved these changes Jul 16, 2025

View reviewed changes

ovflowd approved these changes Jul 16, 2025

View reviewed changes

This comment was marked as off-topic.

Sign in to view

avivkeller approved these changes Jul 16, 2025

View reviewed changes

avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jul 16, 2025

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025

ovflowd enabled auto-merge July 25, 2025 11:17

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025

dario-piotrowicz mentioned this pull request Jul 25, 2025

chore(meta): add Cloudflare docs #8023

Merged

5 tasks

dario-piotrowicz added 9 commits July 25, 2025 14:15

chore: add skew-version support in Cloudflare open-next worker

2ddf2ce

fix typo

15da980

update ids in wrangler.jsonc file

aa39c42

chore: update cloudflare kv binding name

d152c46

chore: fix incorrect cloudflare:deploy script

f3cb1bd

add missingle compat_flag

e2fa3b5

fix incorrect CF_PREVIEW_DOMAIN

db2e6ff

bump open-next adapter and wrangler packages

58a0c25

bump form-data

445def8

dario-piotrowicz force-pushed the dario/open-next-skew-protection branch from f02327a to 445def8 Compare July 25, 2025 13:16

vercel bot deployed to Preview July 25, 2025 13:17 View deployment

dario-piotrowicz added the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025

import open-next adapter in next.config.mjs only if necessary

3e2e029

vercel bot deployed to Preview July 25, 2025 13:53 View deployment

dario-piotrowicz added the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025

ovflowd added this pull request to the merge queue Jul 25, 2025

Merged via the queue into nodejs:main with commit 23b2687 Jul 25, 2025
14 checks passed

dario-piotrowicz deleted the dario/open-next-skew-protection branch July 25, 2025 14:18

Uh oh!

chore: add skew-version support in Cloudflare open-next worker #7980

chore: add skew-version support in Cloudflare open-next worker #7980

Uh oh!

Conversation

dario-piotrowicz commented Jul 14, 2025

Description

Validation

Related Issues

Check List

Uh oh!

vercel bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dario-piotrowicz commented Jul 14, 2025

Uh oh!

Uh oh!

Uh oh!

avivkeller commented Jul 15, 2025

Uh oh!

dario-piotrowicz commented Jul 15, 2025

Uh oh!

Uh oh!

avivkeller commented Jul 15, 2025

Footnotes

Uh oh!

dario-piotrowicz commented Jul 15, 2025

Footnotes

Uh oh!

avivkeller commented Jul 15, 2025

Uh oh!

dario-piotrowicz commented Jul 15, 2025

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

ovflowd commented Jul 16, 2025

Uh oh!

This comment was marked as off-topic.

avivkeller commented Jul 16, 2025

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

avivkeller commented Jul 24, 2025

Uh oh!

dario-piotrowicz commented Jul 25, 2025

Uh oh!

github-actions bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovflowd commented Jul 25, 2025

Uh oh!

dario-piotrowicz commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Jul 14, 2025 •

edited

Loading

codecov bot commented Jul 14, 2025 •

edited

Loading

github-actions bot commented Jul 25, 2025 •

edited

Loading

dario-piotrowicz commented Jul 25, 2025 •

edited

Loading