-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(meta): add Cloudflare docs #8023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(meta): add Cloudflare docs #8023
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive documentation for the Cloudflare build and deployment process for the Node.js website. The documentation covers the OpenNext Cloudflare adapter configuration, Wrangler settings, skew protection mechanisms, and deployment scripts.
- Adds detailed documentation for Cloudflare Worker deployment configuration
- Documents skew protection requirements and environment variables
- Provides information about testing account IDs and KV namespace bindings
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
docs/cloudflare-build-and-deployment.md | New comprehensive documentation file covering Cloudflare deployment configurations, skew protection, and available scripts |
docs/README.md | Adds reference to the new Cloudflare documentation in the main docs index |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #8023 +/- ##
==========================================
+ Coverage 72.95% 73.00% +0.04%
==========================================
Files 95 95
Lines 8317 8317
Branches 215 214 -1
==========================================
+ Hits 6068 6072 +4
+ Misses 2248 2244 -4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
bcb4981
to
2b654d4
Compare
Add (back) some documentation regarding the Cloudflare build, including information about ids, accounts used, skew protection, etc...
2b654d4
to
c8305a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Lighthouse Results
|
Warning This PR should not be merged until #7980 is |
(good call, thanks Aviv 🙂) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All nitpicks, LGTM
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Dario Piotrowicz <[email protected]>
Thank you very much for the suggestions @avivkeller 🙏 I've addressed (mostly just accepted the suggestion) all of them 🙂 |
Thanks all for the reviews 😄🙏 |
Add (back) some documentation regarding the Cloudflare build, including information about ids, accounts used, skew protection, etc...
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.