Skip to content

chore(meta): add Cloudflare docs #8023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dario-piotrowicz
Copy link
Member

Add (back) some documentation regarding the Cloudflare build, including information about ids, accounts used, skew protection, etc...

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 10:52
@dario-piotrowicz dario-piotrowicz requested review from a team as code owners July 25, 2025 10:52
Copy link

vercel bot commented Jul 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 25, 2025 2:18pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for the Cloudflare build and deployment process for the Node.js website. The documentation covers the OpenNext Cloudflare adapter configuration, Wrangler settings, skew protection mechanisms, and deployment scripts.

  • Adds detailed documentation for Cloudflare Worker deployment configuration
  • Documents skew protection requirements and environment variables
  • Provides information about testing account IDs and KV namespace bindings

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/cloudflare-build-and-deployment.md New comprehensive documentation file covering Cloudflare deployment configurations, skew protection, and available scripts
docs/README.md Adds reference to the new Cloudflare documentation in the main docs index

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.00%. Comparing base (230c564) to head (9000bb4).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8023      +/-   ##
==========================================
+ Coverage   72.95%   73.00%   +0.04%     
==========================================
  Files          95       95              
  Lines        8317     8317              
  Branches      215      214       -1     
==========================================
+ Hits         6068     6072       +4     
+ Misses       2248     2244       -4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/add-back-cloudflare-docs branch from bcb4981 to 2b654d4 Compare July 25, 2025 11:00
Add (back) some documentation regarding the Cloudflare build, including information
about ids, accounts used, skew protection, etc...
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025
Copy link
Contributor

github-actions bot commented Jul 25, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 94 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented Jul 25, 2025

Warning

This PR should not be merged until #7980 is

@dario-piotrowicz
Copy link
Member Author

(good call, thanks Aviv 🙂)

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All nitpicks, LGTM

Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Dario Piotrowicz <[email protected]>
@dario-piotrowicz
Copy link
Member Author

All nitpicks, LGTM

Thank you very much for the suggestions @avivkeller 🙏

I've addressed (mostly just accepted the suggestion) all of them 🙂

@dario-piotrowicz
Copy link
Member Author

Thanks all for the reviews 😄🙏

@dario-piotrowicz dario-piotrowicz added this pull request to the merge queue Jul 25, 2025
Merged via the queue into nodejs:main with commit 823a018 Jul 25, 2025
14 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/add-back-cloudflare-docs branch July 25, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants