Sorted timestamps optimization #507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
changed the base branch from
feature/callback-scheduling
to
josh/failed-callbacks
joshuahannan
approved these changes
Aug 11, 2025
| @@ -308,6 +308,67 @@ access(all) contract FlowCallbackScheduler { | |||
| } | |||
| } | |||
|
|
|||
| /// SortedTimestamps maintains a sorted array of timestamps for efficient processing | |||
There was a problem hiding this comment.
Most of this is pretty generic. I wish we could just put this in an ArrayUtils contract that is separate from this so we don't have all this sorting stuff cluttering up this contract, but that might not really be worth putting together
| } | ||
| insertIndex = i + 1 | ||
| } | ||
| self.timestamps.insert(at: insertIndex, timestamp) |
There was a problem hiding this comment.
wow, I didn't even realize this was possible. This is great!
| } | ||
|
|
||
| /// Get all timestamps that are in the past (less than or equal to current timestamp) | ||
| access(all) fun past(current: UFix64): [UFix64] { |
There was a problem hiding this comment.
Suggested change
| access(all) fun past(current: UFix64): [UFix64] { | |
| access(all) fun getPast(current: UFix64): [UFix64] { |
|
|
||
| /// Check if there are any timestamps that need processing | ||
| /// Returns true if processing is needed, false for early exit | ||
| access(all) fun check(current: UFix64): Bool { |
There was a problem hiding this comment.
Suggested change
| access(all) fun check(current: UFix64): Bool { | |
| access(all) fun checkIfTimestampsNeedProcessing(current: UFix64): Bool { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #502
Summary
Optimizes the
process()function inFlowCallbackSchedulerby replacing expensive map filtering with efficient sorted timestamp management, significantly reducing computation when called frequently with no pending work.Changes:
SortedTimestampsstruct: Encapsulates sorted timestamp logic with clean API (add(), remove(), past(), check())check()method enables immediate return when no callbacks need processingpast()method returns only timestamps needing processing without filtering entire mapPerformance Impact
Testing
Added isolated unit tests for
SortedTimestamps struct.