fix: put read-only permission in review thread #7320
Conversation
Signed-off-by: lionelchg <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@lionel-oai, thanks for the PR. Please look at the code review feedback from codex. Also, it's not clear to me how this change will work on Windows (non-WSL) if the experimental sandbox feature isn't enabled. Does it break |
Signed-off-by: lionelchg <[email protected]>
Signed-off-by: lionelchg <[email protected]>
|
I've just passed the code review feedback from codex and tested with 
Will build Windows exec and try it out on my Windows VM later |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Just tried on my Windows VM - a simple review seems to work without any issues @etraut-openai :) 
|
This PR should close #7267 (and also #7311 which is a closed duplicate) where
codexaccidentally changed some files as part of the review process.The review turn context in
core/src/codex.rs::spawn_review_threadnow forcesSandboxPolicy::ReadOnly, so/reviewalways runs under a read-only sandbox regardless of the parent session’s sandbox mode.