Skip to content

fix: put read-only permission in review thread #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −1
Open

fix: put read-only permission in review thread #7320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a79aac8
Put Read-only permission in review thread
lionelchg Nov 26, 2025
5d9779a
Pass comments of codex to enforce read-only at review_conversation level
lionelchg Nov 27, 2025
01a9c63
Correct import and name of policy
lionelchg Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion codex-rs/core/src/codex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1844,6 +1844,7 @@ async fn spawn_review_thread(
per_turn_config.model_family.slug.as_str(),
);

let review_sandbox_policy = SandboxPolicy::ReadOnly;
let per_turn_config = Arc::new(per_turn_config);
let client = ModelClient::new(
per_turn_config.clone(),
Expand All @@ -1865,7 +1866,7 @@ async fn spawn_review_thread(
base_instructions: Some(base_instructions.clone()),
compact_prompt: parent_turn_context.compact_prompt.clone(),
approval_policy: parent_turn_context.approval_policy,
sandbox_policy: parent_turn_context.sandbox_policy.clone(),
sandbox_policy: review_sandbox_policy,
shell_environment_policy: parent_turn_context.shell_environment_policy.clone(),
cwd: parent_turn_context.cwd.clone(),
final_output_json_schema: None,
Expand Down
3 changes: 3 additions & 0 deletions codex-rs/core/src/tasks/review.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ use tokio_util::sync::CancellationToken;
use crate::codex::Session;
use crate::codex::TurnContext;
use crate::codex_delegate::run_codex_conversation_one_shot;
use crate::protocol::SandboxPolicy;
use crate::review_format::format_review_findings_block;
use crate::state::TaskKind;
use codex_protocol::user_input::UserInput;
Expand Down Expand Up @@ -96,6 +97,8 @@ async fn start_review_conversation(
sub_agent_config.user_instructions = None;
// Avoid loading project docs; reviewer only needs findings
sub_agent_config.project_doc_max_bytes = 0;
// Enforce read-only sandbox for the review child session.
sub_agent_config.sandbox_policy = SandboxPolicy::ReadOnly;
// Carry over review-only feature restrictions so the delegate cannot
// re-enable blocked tools (web search, view image).
sub_agent_config
Expand Down
Loading