-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8362482: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java: System.gc() does not provide full GC #26363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back rrich! A progress list of the required criteria for merging this PR into |
@reinrich This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 49 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
* @run junit/othervm --enable-native-access=ALL-UNNAMED UnmountedVThreadNativeMethodAtTop | ||
* @build jdk.test.whitebox.WhiteBox | ||
* @run driver jdk.test.lib.helpers.ClassFileInstaller jdk.test.whitebox.WhiteBox | ||
* @run junit/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI --enable-native-access=ALL-UNNAMED UnmountedVThreadNativeMethodAtTop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use '@run junit/othervm/native' more better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that's better. Thanks for the hint. I wasn't aware of the /native
option.
@reinrich this pull request can not be integrated into git checkout 8362482_whitebox_fullgc
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Thanks! |
Going to push as commit b4028c9.
Your commit was automatically rebased without conflicts. |
/backport :jdk25 |
@reinrich Could not automatically backport
Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk. Note: these commands are just some suggestions and you can use other equivalent commands you know.
Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk with the title Below you can find a suggestion for the pull request body:
|
Call WhiteBox.fullGC() instead of System.gc() for a guaranteed full GC.
It is assumed that one full GC is sufficient for these tests.
Testing was done with fastdebug and release builds on the main platforms and also on Linux/PPC64le and AIX.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26363/head:pull/26363
$ git checkout pull/26363
Update a local copy of the PR:
$ git checkout pull/26363
$ git pull https://git.openjdk.org/jdk.git pull/26363/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26363
View PR using the GUI difftool:
$ git pr show -t 26363
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26363.diff
Using Webrev
Link to Webrev Comment