8362855: Test java/net/ipv6tests/TcpTest.java should report SkippedException when there no ia4addr or ia6addr #26459
Conversation
…ception when there no ia4addr or ia6addr
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
openjdk
bot
changed the title
|
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
| @@ -62,12 +65,10 @@ public class TcpTest extends Tests { | |||
| public static void main (String[] args) throws Exception { | |||
| checkDebug(args); | |||
| if (ia4addr == null) { | |||
| System.out.println ("No IPV4 addresses: exiting test"); | |||
| return; | |||
| throw new SkippedException("No IPV4 addresses: exiting test"); | |||
There was a problem hiding this comment.
Hello @sendaoYan, isn't an import jtreg.SkippedException; required for this change?
There was a problem hiding this comment.
This change require import jtreg.SkippedException, it's already import at line 42.
There was a problem hiding this comment.
You are right - i missed that in my review.
|
@jaikiran Thanks for the reviews. /integrate |
|
Going to push as commit 8fcbb11.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@sendaoYan Pushed as commit 8fcbb11. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
I think the test java/net/ipv6tests/TcpTest.java should report jtreg.SkippedException when there no IPV4 addresses or no IPV6 addresses, rather than just print a messge and then report test run passes.
Change has been verified locally, both enable ipv6 and disable ipv6 on linux. When enable ipv6, test run passes; when disable ipv6, test report jtreg.SkippedException as expected. Test-fix only, no risk.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26459/head:pull/26459$ git checkout pull/26459Update a local copy of the PR:
$ git checkout pull/26459$ git pull https://git.openjdk.org/jdk.git pull/26459/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26459View PR using the GUI difftool:
$ git pr show -t 26459Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26459.diff
Using Webrev
Link to Webrev Comment