Skip to content

8362855: Test java/net/ipv6tests/TcpTest.java should report SkippedException when there no ia4addr or ia6addr #26459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8362855: Test java/net/ipv6tests/TcpTest.java should report SkippedException when there no ia4addr or ia6addr #26459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions test/jdk/java/net/ipv6tests/TcpTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,16 @@
* @library /test/lib
* @build jdk.test.lib.NetworkConfiguration
* jdk.test.lib.Platform
* jtreg.SkippedException
* @run main TcpTest -d
*/

import java.net.*;
import java.io.*;
import java.util.concurrent.TimeUnit;

import jtreg.SkippedException;

public class TcpTest extends Tests {
static ServerSocket server, server1, server2;
static Socket c1, c2, c3, s1, s2, s3;
Expand All @@ -62,12 +65,10 @@ public class TcpTest extends Tests {
public static void main (String[] args) throws Exception {
checkDebug(args);
if (ia4addr == null) {
System.out.println ("No IPV4 addresses: exiting test");
return;
throw new SkippedException("No IPV4 addresses: exiting test");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sendaoYan, isn't an import jtreg.SkippedException; required for this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change require import jtreg.SkippedException, it's already import at line 42.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right - i missed that in my review.

}
if (ia6addr == null) {
System.out.println ("No IPV6 addresses: exiting test");
return;
throw new SkippedException("No IPV6 addresses: exiting test");
}
dprintln ("Local Addresses");
dprintln (ia4addr.toString());
Expand Down