-
Notifications
You must be signed in to change notification settings - Fork 244
fix/CRV3 Improvements #1880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix/CRV3 Improvements #1880
+1,504
−495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subtensor into commit-reveal-v3-improvments
HudsonGraeme
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One observation that weights_version
might be better applied in the reveal round rather than immediately when the hparam is set.. But that's out of scope.
sam0x17
approved these changes
Aug 7, 2025
3 tasks
gztensor
approved these changes
Aug 7, 2025
Broken test will be fixed in this PR opentensor/bittensor#2999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
216_000
(1 week) pulses.100
of the oldest pulses every block.WeightsTlockPayload
and the chain can reveal both payload versions (with and without hotkey).n + reveal_periods
rather thann * reveal_periods
.commit-reveal-version
to enforce client upgrades.reveal_round
s that are in the past via the signed extension.