Skip to content

Conversation

JohnReedV
Copy link
Contributor

@JohnReedV JohnReedV commented Jul 23, 2025

Description

This PR:

  • Modifies the drand pallet to keep only the latest 216_000 (1 week) pulses.
  • Drand pallet will now prune a maximum of 100 of the oldest pulses every block.
  • Hotkey is added toWeightsTlockPayload and the chain can reveal both payload versions (with and without hotkey).
  • The hotkey included in the payload must match the commit extrinsic signer to successfully reveal.
  • Reveal round is now n + reveal_periods rather than n * reveal_periods.
  • Reveals can now occur on any block inside the tempo before the block on which the epoch runs, rather than exclusively immediately before the epoch runs. The requirement is that it is the correct epoch to reveal & the reveal round has been ingested.
  • Adds commit-reveal-version to enforce client upgrades.
  • Rejects reveal_rounds that are in the past via the signed extension.

@JohnReedV JohnReedV added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jul 24, 2025
@JohnReedV JohnReedV marked this pull request as ready for review July 30, 2025 18:26
Copy link
Contributor

@HudsonGraeme HudsonGraeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
One observation that weights_version might be better applied in the reveal round rather than immediately when the hparam is set.. But that's out of scope.

@basfroman
Copy link
Collaborator

basfroman commented Aug 7, 2025

Broken test will be fixed in this PR opentensor/bittensor#2999

@sam0x17 sam0x17 merged commit 2d613cf into devnet-ready Aug 7, 2025
55 of 56 checks passed
@sam0x17 sam0x17 mentioned this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants