Skip to content

Add new CRv4 logic #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 11, 2025
Merged

Add new CRv4 logic #2999

merged 10 commits into from
Aug 11, 2025

Conversation

basfroman
Copy link
Collaborator

@basfroman basfroman commented Jul 30, 2025 •
edited by thewhaleking
Loading

Required:

Deleted:

  • extrinsic bittensor.core.extrinsics.commit_reveal._do_commit_reveal_v3

Added:

  • extrinsic bittensor.core.extrinsics.commit_reveal._do_commit_reveal_v4

Related notes:

  • for SDK users this PR is not a breaking change (unless they used the removed extrinsic which was not recommended).
  • CRV3WeightCommitsV2 will be deprecated in the future.

@github-actions GitHub Actions
Copy link

Bittensor SDK virtual environment sizes by Python version:

Python 3.9: 172 MB
Python 3.10: 162 MB
Python 3.11: 177 MB
Python 3.12: 171 MB
Python 3.13: 171 MB

@basfroman basfroman changed the base branch from master to staging July 30, 2025 17:56
@basfroman basfroman mentioned this pull request Jul 30, 2025
Closed
@basfroman basfroman self-assigned this Jul 30, 2025
@basfroman basfroman changed the title [WIP] Add new crv3 logic Add new CRv4 logic Aug 7, 2025
@basfroman basfroman requested a review from a team August 7, 2025 19:46
@basfroman basfroman mentioned this pull request Aug 7, 2025
Merged
thewhaleking
thewhaleking requested changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall fine. Just small ones.

@basfroman basfroman requested a review from thewhaleking August 7, 2025 20:25
thewhaleking
thewhaleking previously approved these changes Aug 7, 2025
View reviewed changes
@thewhaleking thewhaleking merged commit ee0f422 into staging Aug 11, 2025
280 of 512 checks passed
@thewhaleking thewhaleking deleted the feat/roman/add-new-crv3-logic branch August 11, 2025 18:16
This was referenced Aug 11, 2025
Merged
Merged
This was referenced Sep 3, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewhaleking thewhaleking thewhaleking approved these changes

Assignees

@basfroman basfroman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basfroman @thewhaleking