Skip to content

Conversation

@gmazoyer
Copy link
Contributor

This change is relatively simple and just adds relationships of kind generic and kind attribute to profile schemas corresponding to node schemas having these relationships.

When we load a schema, we make sure to clear all the relationships, except the ones of kind PROFILE such as related_nodes, to create a brand new list of relationships which will account for deleted and new ones. This is very similar to what we do for templates already.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Nov 10, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (4)
  • main
  • stable
  • develop
  • release-.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gma-20251110-ifc1952

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 10, 2025

CodSpeed Performance Report

Merging #7622 will not alter performance

Comparing gma-20251110-ifc1952 (18149d4) with stable (6e6fcbc)1

Summary

✅ 10 untouched

Footnotes

  1. No successful run was found on gma-20251114-ifc1951 (4a6b778) during the generation of this report, so stable (6e6fcbc) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@gmazoyer gmazoyer force-pushed the gma-20251110-ifc1952 branch from 5627938 to e8fb6bb Compare November 12, 2025 08:20
@gmazoyer gmazoyer force-pushed the gma-20251110-ifc1952 branch from e8fb6bb to 18149d4 Compare November 14, 2025 15:04
@github-actions github-actions bot added type/documentation Improvements or additions to documentation group/frontend Issue related to the frontend (React) group/ci Issue related to the CI pipeline labels Nov 14, 2025
@gmazoyer gmazoyer changed the base branch from develop to gma-20251114-ifc1951 November 14, 2025 15:05
@gmazoyer gmazoyer changed the title Add generic/attribute relationships in profile schema IFC-1952 Add generic/attribute relationships in profile schema Nov 14, 2025
@gmazoyer gmazoyer marked this pull request as ready for review November 14, 2025 15:09
@gmazoyer gmazoyer requested a review from a team as a code owner November 14, 2025 15:09
@gmazoyer gmazoyer merged commit 45584a1 into gma-20251114-ifc1951 Nov 14, 2025
81 of 83 checks passed
@gmazoyer gmazoyer deleted the gma-20251110-ifc1952 branch November 14, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/backend Issue related to the backend (API Server, Git Agent) group/ci Issue related to the CI pipeline group/frontend Issue related to the frontend (React) type/documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants