Query tests #39
Merged
Query tests #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarrasseayoub01
requested review from
fmeheust,
shelly-li-sl and
ting-lan-wang
oracle-contributor-agreement
bot
added
the
OCA Verified
ting-lan-wang
approved these changes
Aug 26, 2025
shelly-li-sl
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For TestFind, when gorm scans into map[string]interface{}, there’s no type info for each column. Unlike the underlying drivers for postgres and others that use int64 for their numerical values, godror uses godror.NUMBER type. that's why it comes back as a string.
For TestPluck, the issue is a bit similar in that the custom scanner expects the value that comes from godror to be int64 but it's actually godror.NUMBER.