Skip to content

Query tests #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2025
Merged

Query tests #39

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8dae526
Merge branch 'main' of https://github.com/oracle-samples/gorm-oracle
aarrasseayoub01 Aug 19, 2025
4b4377e
Merge branch 'main' of https://github.com/oracle-samples/gorm-oracle
aarrasseayoub01 Aug 21, 2025
83dc4f8
Fixing TestFind
aarrasseayoub01 Aug 22, 2025
6c0e9a2
Fixing TestPluck
aarrasseayoub01 Aug 22, 2025
3a7e805
Fixing TestSelectWithVariables
aarrasseayoub01 Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 39 additions & 22 deletions tests/query_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import (

"time"

"github.com/godror/godror"
. "github.com/oracle-samples/gorm-oracle/tests/utils"

"gorm.io/gorm"
Expand All @@ -59,7 +60,6 @@ import (
)

func TestFind(t *testing.T) {
t.Skip()
users := []User{
*GetUser("find", Config{}),
*GetUser("find", Config{}),
Expand Down Expand Up @@ -114,8 +114,10 @@ func TestFind(t *testing.T) {
t.Errorf("invalid data type for %v, got %#v", dbName, first[dbName])
}
case "Age":
if _, ok := first[dbName].(uint); !ok {
t.Errorf("invalid data type for %v, got %#v", dbName, first[dbName])
val := fmt.Sprintf("%v", first[dbName])
expected := fmt.Sprint(users[0].Age)
if val != expected {
t.Errorf("expected %v, got %v", expected, val)
}
case "Birthday":
if _, ok := first[dbName].(*time.Time); !ok {
Expand Down Expand Up @@ -146,8 +148,10 @@ func TestFind(t *testing.T) {
t.Errorf("invalid data type for %v, got %v %#v", dbName, resultType, first[dbName])
}
case "Age":
if !strings.Contains(resultType, "int") {
t.Errorf("invalid data type for %v, got %v %#v", dbName, resultType, first[dbName])
val := fmt.Sprintf("%v", first[dbName])
expected := fmt.Sprint(users[0].Age)
if val != expected {
t.Errorf("expected %v, got %v", expected, val)
}
case "Birthday":
if !strings.Contains(resultType, "Time") {
Expand Down Expand Up @@ -194,8 +198,10 @@ func TestFind(t *testing.T) {
t.Errorf("invalid data type for %v, got %#v", dbName, allMap[idx][dbName])
}
case "Age":
if _, ok := allMap[idx][dbName].(uint); !ok {
t.Errorf("invalid data type for %v, got %#v", dbName, allMap[idx][dbName])
val := fmt.Sprintf("%v", allMap[idx][dbName])
expected := fmt.Sprint(users[0].Age)
if val != expected {
t.Errorf("expected %v, got %v", expected, val)
}
case "Birthday":
if _, ok := allMap[idx][dbName].(*time.Time); !ok {
Expand Down Expand Up @@ -230,8 +236,10 @@ func TestFind(t *testing.T) {
t.Errorf("invalid data type for %v, got %v %#v", dbName, resultType, allMap[idx][dbName])
}
case "Age":
if !strings.Contains(resultType, "int") {
t.Errorf("invalid data type for %v, got %v %#v", dbName, resultType, allMap[idx][dbName])
val := fmt.Sprintf("%v", allMap[idx][dbName])
expected := fmt.Sprint(users[0].Age)
if val != expected {
t.Errorf("expected %v, got %v", expected, val)
}
case "Birthday":
if !strings.Contains(resultType, "Time") {
Expand Down Expand Up @@ -714,13 +722,23 @@ func (v Int64) Value() (driver.Value, error) {
}

func (v *Int64) Scan(val interface{}) error {
y := val.(int64)
*v = Int64(y + 1)
switch x := val.(type) {
case int64:
*v = Int64(x + 1)
return nil
case godror.Number:
i, err := strconv.ParseInt(string(x), 10, 64)
if err != nil {
return fmt.Errorf("Int64.Scan: cannot parse godror.Number %q: %w", string(x), err)
}
*v = Int64(i + 1)
return nil
default:
return fmt.Errorf("Int64.Scan: unsupported type %T", val)
}
}

func TestPluck(t *testing.T) {
t.Skip()
users := []*User{
GetUser("pluck-user1", Config{}),
GetUser("pluck-user2", Config{}),
Expand All @@ -730,25 +748,25 @@ func TestPluck(t *testing.T) {
DB.Create(&users)

var names []string
if err := DB.Model(User{}).Where("name like ?", "pluck-user%").Order("name").Pluck("name", &names).Error; err != nil {
if err := DB.Model(User{}).Where("\"name\" like ?", "pluck-user%").Order("\"name\"").Pluck("name", &names).Error; err != nil {
t.Errorf("got error when pluck name: %v", err)
}

var names2 []string
if err := DB.Model(User{}).Where("name like ?", "pluck-user%").Order("name desc").Pluck("name", &names2).Error; err != nil {
if err := DB.Model(User{}).Where("\"name\" like ?", "pluck-user%").Order("\"name\" desc").Pluck("name", &names2).Error; err != nil {
t.Errorf("got error when pluck name: %v", err)
}

sort.Slice(names2, func(i, j int) bool { return names2[i] < names2[j] })
tests.AssertEqual(t, names, names2)

var ids []int
if err := DB.Model(User{}).Where("name like ?", "pluck-user%").Pluck("id", &ids).Error; err != nil {
if err := DB.Model(User{}).Where("\"name\" like ?", "pluck-user%").Pluck("id", &ids).Error; err != nil {
t.Errorf("got error when pluck id: %v", err)
}

var ids2 []Int64
if err := DB.Model(User{}).Where("name like ?", "pluck-user%").Pluck("id", &ids2).Error; err != nil {
if err := DB.Model(User{}).Where("\"name\" like ?", "pluck-user%").Pluck("id", &ids2).Error; err != nil {
t.Errorf("got error when pluck id: %v", err)
}

Expand All @@ -771,7 +789,7 @@ func TestPluck(t *testing.T) {
}

var times []time.Time
if err := DB.Model(User{}).Where("name like ?", "pluck-user%").Pluck("created_at", &times).Error; err != nil {
if err := DB.Model(User{}).Where("\"name\" like ?", "pluck-user%").Pluck("created_at", &times).Error; err != nil {
t.Errorf("got error when pluck time: %v", err)
}

Expand All @@ -780,7 +798,7 @@ func TestPluck(t *testing.T) {
}

var ptrtimes []*time.Time
if err := DB.Model(User{}).Where("name like ?", "pluck-user%").Pluck("created_at", &ptrtimes).Error; err != nil {
if err := DB.Model(User{}).Where("\"name\" like ?", "pluck-user%").Pluck("created_at", &ptrtimes).Error; err != nil {
t.Errorf("got error when pluck time: %v", err)
}

Expand All @@ -789,7 +807,7 @@ func TestPluck(t *testing.T) {
}

var nulltimes []sql.NullTime
if err := DB.Model(User{}).Where("name like ?", "pluck-user%").Pluck("created_at", &nulltimes).Error; err != nil {
if err := DB.Model(User{}).Where("\"name\" like ?", "pluck-user%").Pluck("created_at", &nulltimes).Error; err != nil {
t.Errorf("got error when pluck time: %v", err)
}

Expand Down Expand Up @@ -941,16 +959,15 @@ func TestPluckWithSelect(t *testing.T) {
}

func TestSelectWithVariables(t *testing.T) {
t.Skip()
DB.Save(&User{Name: "select_with_variables"})

rows, _ := DB.Table("users").Where("name = ?", "select_with_variables").Select("? as fake", gorm.Expr("name")).Rows()
rows, _ := DB.Table("users").Where("\"name\" = ?", "select_with_variables").Select("? as fake", gorm.Expr("\"name\"")).Rows()

if !rows.Next() {
t.Errorf("Should have returned at least one row")
} else {
columns, _ := rows.Columns()
tests.AssertEqual(t, columns, []string{"fake"})
tests.AssertEqual(t, columns, []string{"FAKE"})
}

rows.Close()
Expand Down
Loading