fix: accurate build features reporting in reth --version
#19124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leniram159
changed the title
reth --versionreth --version
mattsse
requested changes
Oct 20, 2025
There was a problem hiding this comment.
instead of doing this
we need to remove these from the default features
reth/crates/ethereum/cli/Cargo.toml
Line 38 in a718752
and instead enable them properly in the binaries
mattsse
approved these changes
Oct 20, 2025
| tempfile.workspace = true | ||
|
|
||
| [features] | ||
| default = ["jemalloc", "otlp"] |
There was a problem hiding this comment.
imo this makes sense
because we make them configurable via the binary
mattsse
added
M-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
VERGEN_CARGO_FEATURESwith direct checks ofCARGO_FEATURE_*environment variables. Accurate reporting of features actually enabled for the crate being built.Fixes #19123