Skip to content

fix: accurate build features reporting in reth --version #19124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: accurate build features reporting in reth --version #19124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6aa75a
Fix: Accurate build features reporting in `reth --version`
leniram159 Oct 18, 2025
86e156a
fmt
leniram159 Oct 18, 2025
2d2113c
revert & enable properly in the binaries
leniram159 Oct 20, 2025
eb9dfb4
fix CI
leniram159 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ reth-era-utils = { path = "crates/era-utils" }
reth-errors = { path = "crates/errors" }
reth-eth-wire = { path = "crates/net/eth-wire" }
reth-eth-wire-types = { path = "crates/net/eth-wire-types" }
reth-ethereum-cli = { path = "crates/ethereum/cli" }
reth-ethereum-cli = { path = "crates/ethereum/cli", default-features = false }
reth-ethereum-consensus = { path = "crates/ethereum/consensus", default-features = false }
reth-ethereum-engine-primitives = { path = "crates/ethereum/engine-primitives", default-features = false }
reth-ethereum-forks = { path = "crates/ethereum/hardforks", default-features = false }
Expand Down Expand Up @@ -412,7 +412,7 @@ reth-optimism-node = { path = "crates/optimism/node" }
reth-node-types = { path = "crates/node/types" }
reth-op = { path = "crates/optimism/reth", default-features = false }
reth-optimism-chainspec = { path = "crates/optimism/chainspec", default-features = false }
reth-optimism-cli = { path = "crates/optimism/cli" }
reth-optimism-cli = { path = "crates/optimism/cli", default-features = false }
reth-optimism-consensus = { path = "crates/optimism/consensus", default-features = false }
reth-optimism-forks = { path = "crates/optimism/hardforks", default-features = false }
reth-optimism-payload-builder = { path = "crates/optimism/payload" }
Expand Down
4 changes: 3 additions & 1 deletion bin/reth/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ backon.workspace = true
tempfile.workspace = true

[features]
default = ["jemalloc", "reth-revm/portable"]
default = ["jemalloc", "otlp", "reth-revm/portable"]

otlp = ["reth-ethereum-cli/otlp"]

dev = ["reth-ethereum-cli/dev"]

Expand Down
2 changes: 1 addition & 1 deletion crates/ethereum/cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ tracing.workspace = true
tempfile.workspace = true

[features]
default = ["jemalloc", "otlp"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this makes sense

because we make them configurable via the binary

default = []

otlp = ["reth-tracing/otlp", "reth-node-core/otlp"]

Expand Down
4 changes: 3 additions & 1 deletion crates/optimism/bin/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ tracing.workspace = true
workspace = true

[features]
default = ["jemalloc", "reth-optimism-evm/portable"]
default = ["jemalloc", "otlp", "reth-optimism-evm/portable"]

otlp = ["reth-optimism-cli/otlp"]

jemalloc = ["reth-cli-util/jemalloc", "reth-optimism-cli/jemalloc"]
jemalloc-prof = ["reth-cli-util/jemalloc-prof"]
Expand Down
2 changes: 1 addition & 1 deletion crates/optimism/cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ reth-stages = { workspace = true, features = ["test-utils"] }
reth-optimism-chainspec = { workspace = true, features = ["std", "superchain-configs"] }

[features]
default = ["otlp"]
default = []

# Opentelemtry feature to activate metrics export
otlp = ["reth-tracing/otlp", "reth-node-core/otlp"]
Expand Down
Loading