This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Open
Conversation
added 6 commits
May 27, 2012 20:18
Conflicts: _includes/JB/sharing
Conflicts: _includes/JB/sharing
Conflicts: _includes/JB/sharing
Collaborator
|
I like it. Has merge conflicts now. If you're willing to resubmit, I'll merge. If you have neither the time nor desire to tweak, I'll revisit this during the next release. Thanks for the contribution! |
Author
|
This was submitted nearly three years to the day 😄 Feel free to rebase yourselves; I'm afraid I no longer use jekyll-bootstrap. |
Collaborator
|
Will do. Thanks for the contrib! Sorry it's taken so long to cull the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #15 seems to be the last time discussion on sharing providers came up (which stalled after #20) and nothing seems to have happened since then.
This pull request is my take on how sharing providers could be implemented. The sharing links themselves are built from Jekyll variables and hence, this approach doesn't use any Javascript.
See my photoblog for an example of how it looks.