Skip to content

Edits to clarify the "share" modal - fixes #3567 #3595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+11 −3
Open

Edits to clarify the "share" modal - fixes #3567 #3595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23653aa
Edits to clarify the "share" modal
team-epk Aug 8, 2025
6f32344
Merge branch 'develop' into share-modal
raclim Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions p5.js-web-editor.code-workspace
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"folders": [
{
"path": "."
}
],
"settings": {}
}
Comment on lines +1 to +8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this file? I think this might've been accidentally added in!

6 changes: 3 additions & 3 deletions translations/locales/en-US/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,10 +475,10 @@
"LinkMessage": "There was a problem linking your {{serviceauth}} account to your p5.js Web Editor account. Your {{serviceauth}} account has already been linked to another p5.js Web Editor account."
},
"ShareModal": {
"Embed": "Embed",
"Embed": "Embed sketch",
"Present": "Present",
"Fullscreen": "Fullscreen",
"Edit": "Edit"
"Fullscreen": "Share sketch as view-only",
"Edit": "Share sketch and allow editing"
Comment on lines +478 to +481
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! This is a really minor change, but could we use Title Case capitalization for these?

},
"CollectionView": {
"TitleCreate": "Create collection",
Expand Down