Edits to clarify the "share" modal - fixes #3567 #3595
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
@freaug should get a fair amount of credit for testing it before me and then walking me through how to get to that point. |
There was a problem hiding this comment.
Thanks so much for your teamwork on this @team-epk and @freag!
I'll add in a screenshot below just to show what it currently looks like:
I think this looks overall pretty good! I added in some minor requested changes above—please let me know if you have any questions about them or need any assistance!
| { | ||
| "folders": [ | ||
| { | ||
| "path": "." | ||
| } | ||
| ], | ||
| "settings": {} | ||
| } |
There was a problem hiding this comment.
Could you remove this file? I think this might've been accidentally added in!
| "Embed": "Embed sketch", | ||
| "Present": "Present", | ||
| "Fullscreen": "Fullscreen", | ||
| "Edit": "Edit" | ||
| "Fullscreen": "Share sketch as view-only", | ||
| "Edit": "Share sketch and allow editing" |
There was a problem hiding this comment.
This is looking great! This is a really minor change, but could we use Title Case capitalization for these?
Fixes #3567
Changes:
Slight adjustments to the Share modal text:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123