-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Edits to clarify the "share" modal - fixes #3567 #3595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
136 commits
Select commit
Hold shift + click to select a range
a52d312
apiClient: update extension to ts
clairep94 2480bd1
apiClient: add axios instance type
clairep94 87adc72
device: update extension to ts
clairep94 9efdd25
device: add test
clairep94 462524c
eslint: remove prefer-default-export rule
clairep94 8010af7
device.ts: add edgecase test and refactor
clairep94 cb9ddc5
metaKey.js: update extention to ts
clairep94 f7282c2
metaKey: update to use isMac() -- due to navigator.platform being dep…
clairep94 411eb4a
useKeyDownHandler: refactor to use isMac()
clairep94 e7eaa2c
language-utils.js: update ext to ts
clairep94 53962db
language-utils.ts: add test
clairep94 3efc164
language-utils: add types, passes typecheck
clairep94 fa6d69f
language-utils: refactor for clarity & disable eslint noplusplus rule
clairep94 75b35a3
formatDate: update ext to ts
clairep94 b7fb7a0
formatDate.js: add test
clairep94 2440d6f
formatDate.js: add types and refactor
clairep94 0a9af47
consoleUtils: update extension to ts
clairep94 5302f54
consoleUtils: add tests and bare minimum type
clairep94 2638c32
consoleUtils.ts: add jsdocs and return type
clairep94 723cac3
dispatcher.js: update extention to ts --no-verify
clairep94 e0cb6c7
dispatcher: add unit test
clairep94 0aab549
dispatcher.ts: update with types
clairep94 60f8a6e
dispatcher.ts: add jsdocs
clairep94 04ca29a
remove jsdocs on internal functions to retain git history?
clairep94 e91000f
evaluateExpression: update ext to ts --no-verify
clairep94 0713173
evaluateExpression: add unit test
clairep94 16d84e1
evaluateExpression: add tests
clairep94 6957124
reduxFormUtils: update ext to ts --no-verify
clairep94 97754db
reduxFormUtils: add unit test, no-verify
clairep94 ed0c6f0
reduxFormUtils: delete unused dom-onlyprops function
clairep94 0b223df
reduxFormUtils: add types and jsdocs
clairep94 a52372d
getConfig.js: change to ts, no-verify
clairep94 de6fc10
getConfig.ts: remove circular logic for env check and add types
clairep94 8061e09
migrate getConfig.test to ts
clairep94 058d155
update tests for get config after typing
clairep94 34f0735
add parseStringToType util
clairep94 c6c7d40
update parsers and update useages of getConfig
clairep94 2362807
update formatDate to ts, fix type errors
clairep94 1f5614c
Merge branch 'develop' into pr05/migrate_client_utils_folder
clairep94 8febdcb
Merge branch 'develop' into pr05/migrate_client_utils_folder
clairep94 a9d954f
turn on no-underscore-dangle warning
clairep94 50eab48
getConfig: underscore-dangle stylefix for internal function
clairep94 87d9c0d
evaluateExpression: underscore-dangle stylefix for internal function
clairep94 e387df2
parseString: fix to address nullish check
clairep94 c4af496
device: simplify check for isMac()
clairep94 c67d841
evaluateExpression: address comments
clairep94 589318b
.prettierrc: remove hardcoded babel as parser setting to allow typesc…
clairep94 5f2d878
dispatcher: remove old comments
clairep94 7421ef9
lint-fix after removing prettier hardcoded parser babel
clairep94 5de3876
formatDate: update to named export and update format function to form…
clairep94 2cc486a
remove prettier/prettier eslint error ignore
clairep94 c92d53e
language-utils: update to named export
clairep94 0418d8c
apiClient: update to named export and update instances of importing
clairep94 7173d5d
getConfig: update to named export and update instances of import
clairep94 02428a0
turn underscore dangle to warn in ts only
clairep94 15cabf8
dispatcher: update to use enum
clairep94 bbeac90
getConfig: update to have failOnNotFound option to fail on compiler
clairep94 fcc9a4a
getConfig: handle instances of useage where should throw error in pro…
clairep94 919ab3b
getConfig: cleanup new optional property names
clairep94 de0f4da
cleanup unused import
clairep94 482fb18
reduxFormUtils: address comments for double partial
clairep94 640a0bb
evaluateExpression: update to named export
clairep94 8b3fee5
language-utils: remove check for navigatory == type of undefined
clairep94 6de4d6d
move isTestEnvironemnt to its own module for better testability
clairep94 0ad638f
getConfig: wip update to remove superfluous fail in test env option
clairep94 c832736
fix test
clairep94 31f137c
Update Ukrainian translation
gtmizyuk 9fe530a
Merge branch 'develop' into pr05/migrate_client_utils_folder
clairep94 e11c82a
SkipLink: update type to interface
clairep94 ed2114c
SkipLink: Update to named export
clairep94 c98ad97
parseStringToType: handle when original input is already a bool
clairep94 1c2ce16
getConfig: update to constant case
clairep94 9f80ead
evaluateExpression: update to interface
clairep94 92f2060
remove throwErrorIfNotFound from getConfig
clairep94 bd998b3
remove throwErrorIfNotFound from getConfig - useages
clairep94 8fe7b3e
dispatcher: update to interface
clairep94 23653aa
Edits to clarify the "share" modal
team-epk f978ca2
Updating pt-BR translations (fixing some existing entries and adding …
cassiano bbe84f1
Fixing additional translations
cassiano 16cad7a
More translations fixed
cassiano 17e5b98
Adding new translation `AssetList.maximum` (in us-EN and pt-BR)
cassiano d5da431
One more incorrect translation
cassiano 1a7e439
Avoiding male-gendered words
cassiano 26bb4af
Removing unused pt-BR entries
cassiano 5dc5f8a
Removing unused translations (i.e. entries which do not appear anywhe…
cassiano e2145a7
Removing unused pt-BR translations
cassiano 72f771e
Adding missing translation
cassiano 654d935
Reviewing additional entries
cassiano 2f1caa1
Reviewing additional translations
cassiano 1634692
Fixing translations
cassiano 29669a9
Fixing translations
cassiano 32453f3
Fixing translations
cassiano 7c6d650
login-translation-bug
Nishantkumar012 7617910
Merge branch 'develop' into bug/login-page-translation-error
Nishantkumar012 0f50ca4
adding social media links to the community section of readme
alisonkim12 aeebb57
Merge branch 'develop' into develop
raclim 6f32344
Merge branch 'develop' into share-modal
raclim 42d761f
Update p5Versions.js to include 1.11.10
ksen0 e390dcf
i18n(be): Update Settings and SubmitSaveAllSettings Keys
adi-ray 1f95dc6
adjust toolbar spacing
raclim 6f0158e
remove extra folder
raclim e75e749
Merge branch 'develop' into ksen0-patch-2
raclim 9ba39a5
Merge pull request #3600 from processing/ksen0-patch-2
raclim 9b0a11a
2.18.0
raclim b201533
Merge branch 'release-2.18.0' into release
raclim c486593
Merge branch 'release-2.18.0' into develop
raclim 34123d5
Merge branch 'release' into develop
raclim c555977
Bump path-to-regexp and express
dependabot[bot] ec8de0a
Merge branch 'develop' into pr05/migrate_client_utils_folder
clairep94 f8af6ef
Merge branch 'develop' into updating-ptbr-translations
cassiano b095dba
Merge branch 'processing:develop' into readme-social-links
runningonsideprojects f2a97aa
Fixed Documentation Typo
SHAMIKH-ANWAR 266e9e1
Merge pull request #3553 from clairep94/pr05/migrate_client_utils_folder
raclim 4105ec0
Merge branch 'develop' into readme-social-links
raclim 7f50497
Merge branch 'develop' into updating-ptbr-translations
raclim 4ec6a73
Merge pull request #3593 from cassiano/updating-ptbr-translations
raclim 2511756
Merge branch 'develop' into bug/login-page-translation-error
raclim f623987
Merge branch 'develop' into patch-2
raclim fc5f6ed
Merge pull request #3601 from adi-ray/patch-2
raclim 9e002df
Merge branch 'develop' into develop
raclim 1d7c55c
Merge pull request #3591 from gtmizyuk/develop
raclim 553804a
Merge branch 'develop' into bug/login-page-translation-error
raclim 8b73697
Merge pull request #3598 from Nishantkumar012/bug/login-page-translat…
raclim e551d4b
Merge branch 'develop' into readme-social-links
raclim 57e62c8
Merge pull request #3606 from runningonsideprojects/readme-social-links
raclim 9ee982b
Merge branch 'develop' into fix-doc-typo
raclim b4fd152
Merge pull request #3607 from SHAMIKH-ANWAR/fix-doc-typo
raclim 445c8d1
Merge branch 'develop' into dependabot/npm_and_yarn/multi-e981fcb12d
raclim 8ebf9e3
Merge pull request #3602 from processing/dependabot/npm_and_yarn/mult…
raclim 89e7ec4
fix(i18n): Update Bengali locale code
adi-ray 37bba04
Merge branch 'develop' into patch-2
raclim 9d6e0a0
Merge pull request #3610 from adi-ray/patch-2
raclim f94b1ce
Edits to clarify the "share" modal
team-epk 4334518
minor edits to earlier commit (#3595)
team-epk 7dd44ac
Edits to clarify the "share" modal
team-epk a0801e2
Merge branch 'share-modal' of https://github.com/team-epk/p5.js-web-e…
team-epk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "folders": [ | ||
| { | ||
| "path": "." | ||
| } | ||
| ], | ||
| "settings": {} | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -475,10 +475,10 @@ | |
| "LinkMessage": "There was a problem linking your {{serviceauth}} account to your p5.js Web Editor account. Your {{serviceauth}} account has already been linked to another p5.js Web Editor account." | ||
| }, | ||
| "ShareModal": { | ||
| "Embed": "Embed", | ||
| "Embed": "Embed sketch", | ||
| "Present": "Present", | ||
| "Fullscreen": "Fullscreen", | ||
| "Edit": "Edit" | ||
| "Fullscreen": "Share sketch as view-only", | ||
| "Edit": "Share sketch and allow editing" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is looking great! This is a really minor change, but could we use Title Case capitalization for these? |
||
| }, | ||
| "CollectionView": { | ||
| "TitleCreate": "Create collection", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove this file? I think this might've been accidentally added in!