Skip to content

No need to install wheel any more #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

Conversation

stefanor
Copy link
Contributor

setuptools has had a native bdist_wheel since 70.1.0: https://setuptools.pypa.io/en/latest/history.html#v70-1-0

@stefanor stefanor marked this pull request as draft April 28, 2025 12:50
@stefanor stefanor force-pushed the no-wheel branch 2 times, most recently from 28ca0f7 to 1518555 Compare April 28, 2025 16:25
@stefanor stefanor marked this pull request as ready for review April 28, 2025 16:33
@stefanor
Copy link
Contributor Author

stefanor commented Apr 28, 2025

It would probably be good to have some pep517 integration tests, those will have to use versions of cffi from PyPI, which makes it impossible to test any coupled changes. (no longer necessary, it actually works just fine in PEP517 mode)

@mattip
Copy link
Contributor

mattip commented Jun 25, 2025

There are merge conflicts

…these tests

Previously we relied on pip to build the packages in non-PEP517 mode,
which implied no build isolation.

The latest `virtualenv` (with pypa/virtualenv#2868) won't include
`wheel` in the virtualenv, which will mean that pip uses PEP-517 mode,
which is isolated by default.
@stefanor
Copy link
Contributor Author

Rebased.

@mattip mattip merged commit 24e42cb into python-cffi:main Aug 21, 2025
32 checks passed
@mattip
Copy link
Contributor

mattip commented Aug 21, 2025

Thanks @stefanor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants