Add ability to add MIL ops to ET that are not yet in coremltools #12648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12648
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 95 PendingAs of commit d8eb2b6 with merge base 0fbd6d4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
metascroy
changed the title
This PR needs a
|
YifanShenSZ
approved these changes
Jul 18, 2025
|
Can I get a stamp @cccclai? I need someone from PyTorch to approve to merge |
This was referenced Jul 21, 2025
billmguo
approved these changes
Jul 21, 2025
cccclai
approved these changes
Jul 21, 2025
derekxu
approved these changes
Jul 21, 2025
metascroy
force-pushed
the
add-tmp-coreml-ops
branch
from
b37ff5f to
ec79df7
Compare
metascroy
added a commit
that referenced
this pull request
Jul 21, 2025
This is CoreML support for blockwise/channelwise quantization of linear/embedding layers using torchao APIs. This PR is based on top of #12648, and will be rebased once that lands to show the changes isolated to quantization.
metascroy
added a commit
that referenced
this pull request
Jul 23, 2025
…uantization APIs (#12665) This switches the ANE model to use to_edge_transform_and_lower and torchao quantization APIs. To use to_edge_transform_and_lower, we first need to land: #12629 To use torchao quant APIs, we first need to land #12648 and #12664. This PR contains all of the changes from those PRs because it is rebased on them. I will rebase on main once those PRs land to make this easier to review.
Conarnar
pushed a commit
to Conarnar/executorch
that referenced
this pull request
Jul 25, 2025
…orch#12648) This introduces torch_ops.py in ET's CoreML compiler. This lets us add critical MIL ops that are not yet in ET's version of coremltools.
Conarnar
pushed a commit
to Conarnar/executorch
that referenced
this pull request
Jul 25, 2025
This is CoreML support for blockwise/channelwise quantization of linear/embedding layers using torchao APIs. This PR is based on top of pytorch#12648, and will be rebased once that lands to show the changes isolated to quantization.
Conarnar
pushed a commit
to Conarnar/executorch
that referenced
this pull request
Jul 25, 2025
…uantization APIs (pytorch#12665) This switches the ANE model to use to_edge_transform_and_lower and torchao quantization APIs. To use to_edge_transform_and_lower, we first need to land: pytorch#12629 To use torchao quant APIs, we first need to land pytorch#12648 and pytorch#12664. This PR contains all of the changes from those PRs because it is rebased on them. I will rebase on main once those PRs land to make this easier to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces torch_ops.py in ET's CoreML compiler. This lets us add critical MIL ops that are not yet in ET's version of coremltools.