Skip to content

Arm backend: Add addmm decomposition pass and test #12668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tbergkvist
Copy link
Contributor

@tbergkvist tbergkvist commented Jul 21, 2025

Decomposes addmm into matmul and add operators.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Decomposes addmm into matmul and add operators.

Change-Id: I9f67f6a6e6b63b22065ed2bc918bb4deaaaffd74
Signed-off-by: Teo Bergkvist <[email protected]>
@tbergkvist tbergkvist requested a review from digantdesai as a code owner July 21, 2025 08:15
Copy link

pytorch-bot bot commented Jul 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12668

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 9e5e461 with merge base b7eff08 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2025
@tbergkvist
Copy link
Contributor Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jul 21, 2025
@tbergkvist
Copy link
Contributor Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot bot added the release notes: arm Changes to the ARM backend delegate label Jul 21, 2025
@tbergkvist
Copy link
Contributor Author

@pytorchbot label "ciflow/trunk"

Copy link

pytorch-bot bot commented Jul 21, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated CI error.

Approved.

@Sebastian-Larsson Sebastian-Larsson merged commit fab5687 into pytorch:main Jul 22, 2025
293 of 296 checks passed
@tbergkvist tbergkvist deleted the Arm-backend-Add-addmm-decomposition-pass-and-test branch July 22, 2025 08:09
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
Decomposes addmm into matmul and add operators.

Signed-off-by: Teo Bergkvist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants