Skip to content

Build EXTENSION_DATA_LOADER with size_test #12678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 64 commits into from
Jul 23, 2025
Merged

Build EXTENSION_DATA_LOADER with size_test #12678

merged 64 commits into from
Jul 23, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jul 21, 2025

size_test.cpp uses FileDataLoader. Looks like this happens to work currently because of the missing cmake_deps.toml entry that gets fixed in #12744

swolchok added 30 commits July 13, 2025 09:47
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added 9 commits July 21, 2025 16:05
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok added release notes: none Do not include this in the release notes ciflow/trunk labels Jul 22, 2025
swolchok added 2 commits July 22, 2025 21:23
[ghstack-poisoned]
[ghstack-poisoned]
@@ -1 +1 @@
Subproject commit ea8691c6200c702cf28dd2aa2da902e9299b6bb3
Subproject commit f09feca15849a790c05b3b7855e7c62ce26ba94b
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Contributor Author

@swolchok swolchok Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, good catch, should be in the EXPORT PR or split out

@@ -249,7 +249,7 @@ check_required_options_on(

check_conflicting_options_on(
IF_ON EXECUTORCH_BUILD_ARM_BAREMETAL CONFLICTS_WITH
EXECUTORCH_BUILD_EXTENSION_DATA_LOADER EXECUTORCH_BUILD_PTHREADPOOL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this or install_executorch used by the ci scripts was the reason it was working before?

If we want to not enable this by default then perhaps we should also update install_executorch (if not using the default preset already).

And that should also make the baremetal build fail. I also realized that we don't run the baremetal size-test binary on the CI, so we may need to fix that too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason it was working before?

you may be interested in later PRs in this stack, particularly #12744

@swolchok
Copy link
Contributor Author

build-demo-ios looks like a flake, noting CI looks good before removing the accidental tokenizers bump and starting merge of the stack

swolchok added 4 commits July 23, 2025 11:07
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok requested a review from digantdesai July 23, 2025 21:31
Base automatically changed from gh/swolchok/522/head to main July 23, 2025 21:31
@swolchok swolchok requested a review from SS-JIA as a code owner July 23, 2025 21:31
[ghstack-poisoned]
@@ -23,11 +23,17 @@ cmake_install_executorch_lib() {
update_tokenizers_git_submodule
local EXTRA_BUILD_ARGS="${@}"

if [[ "$EXTRA_BUILD_ARGS" == *"-DEXECUTORCH_BUILD_ARM_BAREMETAL=ON"* ]]; then
local BUILD_DATA_LOADER="OFF"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: is double quote needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, but I also don't think it hurts

@swolchok
Copy link
Contributor Author

merging based on previous good CI run

@swolchok swolchok merged commit 1cd4ac0 into main Jul 23, 2025
171 of 199 checks passed
@swolchok swolchok deleted the gh/swolchok/524/head branch July 23, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants