Skip to content

Set up CMake build for extension/evalue_util #12691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 74 commits into from
Jul 23, 2025
Merged

Conversation

swolchok
Copy link
Contributor

It didn't have one. Now it does.

swolchok added 30 commits July 13, 2025 09:47
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok added ciflow/trunk ciflow/binaries/all Release PRs with this label will build wheels for all python versions labels Jul 22, 2025
@swolchok
Copy link
Contributor Author

arm-cortex-m-size-test appears to have failed more than once now with

In file included from /pytorch/executorch/extension/data_loader/mmap_data_loader.cpp:19:
/pytorch/executorch/extension/data_loader/../../../executorch/extension/data_loader/mman.h:18:10: fatal error: sys/mman.h: No such file or directory
18 | #include <sys/mman.h>

puzzling, will have to investigate. other tests are looking pretty good; test-llama-runner-mac (fp32, coreml) looks like it's probably either a flake or a different PR because it's an output change, which this PR really should not cause.

@swolchok
Copy link
Contributor Author

will have to investigate.

repros on previous PR #12678

does not repro on #12667.

Moving investigation to #12678

swolchok added 7 commits July 22, 2025 15:09
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

test-llama-runner-mac (fp32, coreml) is still failing! very strange

@swolchok
Copy link
Contributor Author

test-models-linux-basic mv3 failure https://github.com/pytorch/executorch/actions/runs/16456606096/job/46515099970?pr=12691 failure looks like an infra flake

test-llama-runner-mac (fp32, coreml) is still failing! very strange

failure does not repro locally

swolchok added 6 commits July 23, 2025 11:07
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

test-llama-runner-mac (fp32, coreml) is still failing! very strange

failure does not repro locally

passing now, must've been some weird transient issue

swolchok added 2 commits July 23, 2025 15:16
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/swolchok/524/head to main July 23, 2025 23:29
@swolchok
Copy link
Contributor Author

merging based on previous good CI run

@swolchok swolchok merged commit cfefd2c into main Jul 23, 2025
244 of 478 checks passed
@swolchok swolchok deleted the gh/swolchok/525/head branch July 23, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries/all Release PRs with this label will build wheels for all python versions ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants