Skip to content

ET compiler specific macros for decorators #13637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: gh/ivayloen/2/base
Choose a base branch
from
Open

ET compiler specific macros for decorators #13637

wants to merge 3 commits into from

Conversation

ivayloen
Copy link
Contributor

@ivayloen ivayloen commented Aug 25, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Put restrict behind macros that we can switch based on type of compiler
Additional windows specific issue is passing static constexpr const char op_name[] as template argument. Hide that decoration behind a macro as well to not affect the rest of the builds.

Differential Revision: D78854133

@ivayloen
ET compiler specific macros for decorators
62fd180 
Put restrict behind macros that we can switch based on type of compiler
Additional windows specific issue is passing static constexpr const char op_name[] as template argument. Hide that decoration behind a macro as well to not affect the rest of the builds.

Differential Revision: [D78854133](https://our.internmc.facebook.com/intern/diff/D78854133/)

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13637

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit f10ff9d with merge base 7cf8a5e (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Aug 25, 2025
Open
Open
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78854133

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@ivayloen
Update on "ET compiler specific macros for decorators"
dc4e697 
Put restrict behind macros that we can switch based on type of compiler
Additional windows specific issue is passing static constexpr const char op_name[] as template argument. Hide that decoration behind a macro as well to not affect the rest of the builds.

Differential Revision: [D78854133](https://our.internmc.facebook.com/intern/diff/D78854133/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78854133

@ivayloen
Update on "ET compiler specific macros for decorators"
f10ff9d 
Put restrict behind macros that we can switch based on type of compiler
Additional windows specific issue is passing static constexpr const char op_name[] as template argument. Hide that decoration behind a macro as well to not affect the rest of the builds.

Differential Revision: [D78854133](https://our.internmc.facebook.com/intern/diff/D78854133/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78854133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsharma35 hsharma35 hsharma35 approved these changes

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivayloen @facebook-github-bot @hsharma35