ET use compiler macros in ops #13638
Open
+114
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new compiler macros to fix operator library builds. Additional issues, isnan and signbit supported types are only on float, double and long double. Apply static cast to avoid msvc compiler error. Differential Revision: [D78854136](https://our.internmc.facebook.com/intern/diff/D78854136/) [ghstack-poisoned]
This was referenced Aug 25, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13638
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit 6f242ca with merge base 7cf8a5e ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ivayloen
added a commit
that referenced
this pull request
Aug 25, 2025
Use new compiler macros to fix operator library builds. Additional issues, isnan and signbit supported types are only on float, double and long double. Apply static cast to avoid msvc compiler error. Differential Revision: [D78854136](https://our.internmc.facebook.com/intern/diff/D78854136/) ghstack-source-id: 305107633 Pull Request resolved: #13638
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78854136 |
hsharma35
approved these changes
Aug 25, 2025
Use new compiler macros to fix operator library builds. Additional issues, isnan and signbit supported types are only on float, double and long double. Apply static cast to avoid msvc compiler error. Differential Revision: [D78854136](https://our.internmc.facebook.com/intern/diff/D78854136/) [ghstack-poisoned]
ivayloen
added a commit
that referenced
this pull request
Aug 26, 2025
Pull Request resolved: #13638 Use new compiler macros to fix operator library builds. Additional issues, isnan and signbit supported types are only on float, double and long double. Apply static cast to avoid msvc compiler error. Differential Revision: [D78854136](https://our.internmc.facebook.com/intern/diff/D78854136/) ghstack-source-id: 305793447
|
This pull request was exported from Phabricator. Differential Revision: D78854136 |
|
Overall, these changes look reasonable to me. The main concern that I want to address prior to approving is ensuring that we have GitHub CI coverage for all platforms we're supporting internally. As @mergennachin mentioned, if you can use clang-cl internally, that would align with what we're supporting via CMake. We could add CI coverage for the Windows build via buck to guard this. |
Use new compiler macros to fix operator library builds. Additional issues, isnan and signbit supported types are only on float, double and long double. Apply static cast to avoid msvc compiler error. Differential Revision: [D78854136](https://our.internmc.facebook.com/intern/diff/D78854136/) [ghstack-poisoned]
ivayloen
added a commit
that referenced
this pull request
Aug 26, 2025
Pull Request resolved: #13638 Use new compiler macros to fix operator library builds. Additional issues, isnan and signbit supported types are only on float, double and long double. Apply static cast to avoid msvc compiler error. ghstack-source-id: 305811880 Differential Revision: [D78854136](https://our.internmc.facebook.com/intern/diff/D78854136/)
|
This pull request was exported from Phabricator. Differential Revision: D78854136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Use new compiler macros to fix operator library builds.
Additional issues,
isnan and signbit supported types are only on float, double and long double. Apply static cast to avoid msvc compiler error.
Differential Revision: D78854136