Allow Nova Linux job read access to RUNNER envvars #7413
Merged
+11
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huy Do <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
meta-cla
bot
added
the
CLA Signed
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
zxiiro
previously requested changes
Oct 27, 2025
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
atalman
approved these changes
Oct 28, 2025
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
huydhn
dismissed
zxiiro’s stale review
Ty for the review! I'm not sure why this blocks merge now. Weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as pytorch/pytorch#165821, but for non-ROCm jobs. There are some
test_linux_jobsthat are obsoleted, and don't work anymore. I can clean them up in another PR. We are all onlinux_job_v2now.I also need to update the test workflow to get rid of
3.9andcu121.