Skip to content

Allow Nova Linux job read access to RUNNER envvars #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 28, 2025
Merged

Allow Nova Linux job read access to RUNNER envvars #7413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4d7d79e
Allow Nova Linux job read access to RUNNER envvars
huydhn Oct 26, 2025
0310e04
Update tests
huydhn Oct 26, 2025
3ee9193
Another round of updating test
huydhn Oct 26, 2025
aac15ad
Fix typo
huydhn Oct 27, 2025
5b46186
Another tweak
huydhn Oct 27, 2025
383b557
Urgh
huydhn Oct 27, 2025
59bd0ab
Leave linux_job alone, we will clean it up anyway
huydhn Oct 28, 2025
7a4cbb2
Ok dokey
huydhn Oct 28, 2025
cd6bd90
Clean up old tests to make CI green
huydhn Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/setup-linux/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ runs:
run: |
env | grep '^GITHUB' >> "${RUNNER_TEMP}/github_env_${GITHUB_RUN_ID}"
env | grep '^CI' >> "${RUNNER_TEMP}/github_env_${GITHUB_RUN_ID}"
env | grep '^RUNNER' >> "${RUNNER_TEMP}/github_env_${GITHUB_RUN_ID}"

- name: Setup useful environment variables
shell: bash
Expand Down
16 changes: 0 additions & 16 deletions .github/workflows/test_linux_job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,6 @@ jobs:
gpu-arch-version: ""
script: |
[[ "${SECRET_NOT_A_SECRET_USED_FOR_TESTING}" == "SECRET_VALUE" ]] || exit 1
test-cpu:
uses: ./.github/workflows/linux_job.yml
with:
job-name: "linux-py3.9-cpu"
runner: linux.2xlarge
test-infra-repository: ${{ github.repository }}
test-infra-ref: ${{ github.ref }}
submodules: "recursive"
gpu-arch-type: cpu
gpu-arch-version: ""
script: |
conda create --yes --quiet -n test python=3.9
conda activate test
python3 -m pip install --index-url https://download.pytorch.org/whl/nightly/cpu --pre torch
# Can import pytorch
python3 -c 'import torch'
test-gpu:
uses: ./.github/workflows/linux_job.yml
strategy:
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/test_linux_job_v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ jobs:
permissions:
id-token: write
with:
job-name: "linux-py3.9-cpu"
job-name: "linux-py3.10-cpu"
runner: linux.2xlarge
test-infra-repository: ${{ github.repository }}
test-infra-ref: ${{ github.ref }}
submodules: "recursive"
gpu-arch-type: cpu
gpu-arch-version: ""
script: |
conda create --yes --quiet -n test python=3.9
conda create --yes --quiet -n test python=3.10
conda activate test
python3 -m pip install --index-url https://download.pytorch.org/whl/nightly/cpu --pre torch
# Can import pytorch
Expand All @@ -34,26 +34,26 @@ jobs:
id-token: write
strategy:
matrix:
runner_type: ["linux.4xlarge.nvidia.gpu", "linux.g5.4xlarge.nvidia.gpu"]
runner_type: ["linux.g5.4xlarge.nvidia.gpu"]
with:
job-name: "linux-py3.9-cu121"
job-name: "linux-py3.10-cu128"
runner: ${{ matrix.runner_type }}
test-infra-repository: ${{ github.repository }}
test-infra-ref: ${{ github.ref }}
submodules: ${{ 'true' }}
gpu-arch-type: cuda
gpu-arch-version: "12.1"
gpu-arch-version: "12.8"
timeout: 60
script: |
nvidia-smi
nvcc --version | grep "cuda_12.1"
conda create --yes --quiet -n test python=3.9
nvcc --version | grep "cuda_12.8"
conda create --yes --quiet -n test python=3.10
conda activate test
python3 -m pip install --index-url https://download.pytorch.org/whl/nightly/cu121 --pre torch
python3 -m pip install --index-url https://download.pytorch.org/whl/nightly/cu128 --pre torch
# Can import pytorch, cuda is available
python3 -c 'import torch;cuda_avail = torch.cuda.is_available();print("CUDA available: " + str(cuda_avail));assert(cuda_avail)'
python3 -c 'import torch;t = torch.ones([2,2], device="cuda:0");print(t);print("tensor device:" + str(t.device))'
python3 -c 'import torch;assert(torch.version.cuda == "12.1")'
python3 -c 'import torch;assert(torch.version.cuda == "12.8")'
test-gpu-containers:
uses: ./.github/workflows/linux_job_v2.yml
permissions:
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
id-token: write
strategy:
matrix:
python_version: ["3.9", "3.10", "3.11", "3.12"]
python_version: ["3.10", "3.11", "3.12", "3.13"]
with:
runner: linux.2xlarge
test-infra-repository: ${{ github.repository }}
Expand Down
Loading