docs: improve --help text for --start-group and --end-group - #1753
Open
Vedant Madane (VedantMadane) wants to merge 1 commit into
Open
docs: improve --help text for --start-group and --end-group#1753Vedant Madane (VedantMadane) wants to merge 1 commit into
Vedant Madane (VedantMadane) wants to merge 1 commit into
Conversation
Explain that archives in a group are searched iteratively until no new undefined symbols are resolved, matching common ld(1) wording. Fixes qualcomm#1743 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
| Alias<u>; | ||
| defm start_group : mDashDeprWithOpt<"start-group", "start_group", | ||
| "Start a group">, | ||
| "Archives between --start-group and --end-group are searched repeatedly until no new undefined symbols are resolved">, |
Contributor
There was a problem hiding this comment.
A new line marker ('\n') would be helpful in the help text here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand
--helpstrings for--start-group/--end-group(and short aliases) to explain that archives in the group are searched iteratively until no new undefined symbols are resolved.Test plan
GnuLinkerOptions.tdFixes #1743