Skip to content

docs: improve --help text for --start-group and --end-group #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vedant Madane (VedantMadane) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: improve --help text for --start-group and --end-group #1753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions include/eld/Driver/GnuLinkerOptions.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,7 @@ def u_alias : JJ<"undefined=">,
Group<grp_resolveropt>,
Alias<u>;
defm start_group : mDashDeprWithOpt<"start-group", "start_group",
"Start a group">,
"Archives between --start-group and --end-group are searched repeatedly until no new undefined symbols are resolved">,

@parth-07 Parth (parth-07) Aug 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new line marker ('\n') would be helpful in the help text here.

Group<grp_resolveropt>;
def start_lib : FF<"start-lib">,
HelpText<"Start a library">,
Expand All @@ -710,10 +710,11 @@ def start_lib_thin : FF<"start-lib-thin">,
HelpText<"Start a thin library">,
Group<grp_resolveropt>;
def alias_start_group : Flag<["-"], "(">,
HelpText<"Start a group">,
HelpText<"Start a group (same as --start-group)">,
Group<grp_resolveropt>,
Alias<start_group>;
defm end_group : mDashDeprWithOpt<"end-group", "end_group", "End a group">,
defm end_group : mDashDeprWithOpt<"end-group", "end_group",
"Archives between --start-group and --end-group are searched repeatedly until no new undefined symbols are resolved">,
Group<grp_resolveropt>;
def end_lib : FF<"end-lib">,
HelpText<"End a library">,
Expand All @@ -722,7 +723,7 @@ def end_lib_thin : FF<"end-lib-thin">,
HelpText<"End a thin library">,
Group<grp_resolveropt>;
def alias_end_group : Flag<["-"], ")">,
HelpText<"End a group">,
HelpText<"End a group (same as --end-group)">,
Group<grp_resolveropt>,
Alias<end_group>;
def as_needed : FF<"as-needed">,
Expand Down