Skip to content

Fix Windows build and CI with libusb #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2025
Merged

Fix Windows build and CI with libusb #253

merged 3 commits into from
Jul 24, 2025

Conversation

will-v-pi
Copy link
Contributor

Fix Windows build with MSVC, and fix the libusb inclusion in the Windows CI

@will-v-pi will-v-pi added this to the 2.1.2 milestone Jul 15, 2025
@will-v-pi will-v-pi requested a review from kilograham July 15, 2025 13:35
lurch
lurch reviewed Jul 15, 2025
View reviewed changes
@lurch
Copy link
Contributor

lurch commented Jul 15, 2025

This addresses part of the problem identified in #251

@will-v-pi will-v-pi merged commit f4b5632 into develop Jul 24, 2025
40 checks passed
@will-v-pi will-v-pi deleted the fix-win branch July 24, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch left review comments

@kilograham kilograham Awaiting requested review from kilograham

+1 more reviewer

@ndabas ndabas ndabas left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@will-v-pi @lurch @ndabas