-
-
Notifications
You must be signed in to change notification settings - Fork 915
Updating Example App to use React Native 0.81.1 #3940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Example App to use React Native 0.81.1 #3940
Conversation
|
FYI in this PR I had to put the changes from PR #3937, because otherwise the example app for iOS wouldn't build. It would make sense to merge PR #3937 before this one and #3941. In addition, I also had to update |
b359528 to
9e8bd6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the example app to use React Native 0.81.1 and makes several quality improvements. It includes upgrading dependencies, improving error handling, replacing deprecated imports, and enhancing the navigation structure for better user experience.
- Updates React Native from 0.80.2 to 0.81.1 and upgrades related dependencies
- Refactors debounce library usage and improves TypeScript configuration
- Enhances modal presentation with React Navigation modals and native modals
Reviewed Changes
Copilot reviewed 43 out of 46 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/MapView.tsx | Updates debounce library usage for API compatibility |
| package.json | Upgrades debounce to v2.2.0 and adds eslint-plugin-prettier |
| ios/RNMBX/ShapeAnimators/ | Renames method from create to generate for consistency |
| example/ files | Updates SafeAreaView imports to use react-native-safe-area-context |
| example/src/examples/CacheManagement/ | Converts from class to functional component and reorganizes structure |
| example/src/examples/SymbolCircleLayer/Earthquakes.tsx | Refactors modal presentation and improves component organization |
| example/src/examples/Map/MapAndRNNavigation.js | Enhances modal presentation with multiple navigation options |
| Various example files | Removes deprecated Page wrapper usage throughout examples |
Comments suppressed due to low confidence (1)
example/src/examples/SymbolCircleLayer/ShapeSourceIcon.js:1
- Text components cannot have border radius, shadow properties, or backgroundColor applied directly. These styling properties should be applied to a wrapping View component instead.
import React from 'react';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| /** @type ExampleWithMetadata['metadata'] */ | ||
| const metadata = { | ||
| title: 'Animaated point', | ||
| title: 'Animated point', |
Copilot
AI
Sep 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title was corrected from "Animaated point" to "Animated point" - this fixes the spelling error.
Copilot uses AI. Check for mistakes.
…rce Icons example
Running yarn generate to update docs
|
@whiteHatCip I'm concerned about this PR getting bigger and bigger. Also I'm not 100% sure about converting examples to typescript. Those are code examples serving as documentation/demonstrating the use of rnmapbox and typescript generally means a bit more noise. |
@mfazekas I see your point. The thing is that saw the notification from the Copilot review: Corrected one suggestion for a useless wrapper, and noticed a couple more things, like an error that would have caused a crash related to the ShapeSource example. Anyway, I won't add any more changes to the changes from this PR. You approved it, early this morning, Shall we merge it as is, or should I revert that last file I turned from JS to TS for this PR to be merged? What is exactly that you are concerned about? Is it just about that single js-to-tsx file? |
Description
Updating Example App to use React Native 0.81.0
Because of the high amount of files changed, I advise you to review this PR using Google Chrome, as it seems that from Safari the Github UI hangs when entering the Files Changed tab
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp.Changes
SafeAreaViewfromreact-native-safe-area-contextto get rid of deprecation warnings for importing it fromreact-native