-
-
Notifications
You must be signed in to change notification settings - Fork 914
fix: 'react/utils/FollyConvert.h' file not found #3937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 'react/utils/FollyConvert.h' file not found #3937
Conversation
|
@whiteHatCip thanks much for looking into this. So for upgrade I've checked and the diff looks good you made all changes shown by: For the RCTFollyConvert.h => FollyConvert.h, which RN versions is that compatible with? And shouldn't we use #import <react/utils/FollyConvert.h>? |
|
@mfazekas speaking of using
you are totally right, but when I was trying to update my app using a patch-package patch, that import was not working properly, therefore I did fallback to that import using quotes. Now I just updated those imports and the example app is building successfully ✌🏻 And lastly, my own application is having issues when trying to run on android too. Are you experiencing the same issue too? |
0253332 to
4b9ab15
Compare
4f95936 to
2b49028
Compare
9b1bb85 to
a95c23d
Compare
rnmapbox#3937 In order to be able to run the example app that uses react-native 0.81.0
rnmapbox#3937 In order to be able to run the example app that uses react-native 0.81.0
In order to be able to run the example app that uses react-native 0.81.0
The new filename will be RNMBXFollyConvert.h Co-Authored-By: Miklós Fazekas <[email protected]>
b3bbaff to
02d4107
Compare
Description
After upgrading to React Native 0.81.0, an error stating that RCTFollyConvert.h could not be found, I had to handle the error and realized that the file that could not be found had been deprecated, hence, rather than trying to find a way to import that same file, it was the case that the deprecated file had to be ditched in favor of the one that replaces it
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp.iOS only Changes
Added
RNMBXFollyConvert.hfor compatibilityIntroduced a new header
RNMBXFollyConvert.hthat conditionally importsRNMBXFollyConvert.hfrom the correct location depending on the build configuration (meaning if the user uses use_frameworks! :linkage => :static in their pod file, which is a very common scenario for developers using firebase in their react native apps).This change was necessary because the import path for
react/utils/FollyConvert.hdiffers when building with or withoutuse_frameworks!(static libs vs modular headers). Some environments also expose legacy or platform-specific paths. By centralizing the conditional imports in a single file, we avoid scattered#if __has_includeblocks and ensure consistent, portable compilation across setups. A backward-compatible import is offered for older react-native users that still need to importRCTFollyConvert.hfile