-
Notifications
You must be signed in to change notification settings - Fork 7
Hides UI panels by default #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eholum-nasa should we update the README.md about the shortcuts to bring back the panels?, just for the beginners or is it not needed?
|
My vote would be to add these instructions to the README because there doesn't seem to be a menu that lets you do this without keyboard shortcuts. |
Thanks |
|
@louislelay please update the readme with the proper description |
|
Done @saikishor and @sea-bass! |
|
Looks good! I think we could also probably link to something like this video in the documentation for general simulate tools. I don't think it belongs here, but in general, I wonder if we could do something similar to rviz configs that get loaded in. For example, I decided that rangefinders shouldn't be on by default, so added this, but I imagine that it could be useful to load certain simulate window configs based on what is desired. Of course, it would be hard to integrate because we would have to parse yet another file and do more manual mappings of strings to simulate flags, but it would be doable. |
eholum-nasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @louislelay! Some minor, minor nits on the README but this is a nice change :)
Co-authored-by: Erik Holum <[email protected]>
Co-authored-by: Erik Holum <[email protected]>
eholum-nasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit fix suggestion
|
Nice! Thank you everyone for taking a look :) |
The UI no longer opens with the panels visible by default. They can be toggled back on using
TaborShift+Tab.