uefi: memory safety fixes (UB!) #1758
Open
+21
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
bugfix-mem-gop
branch
from
74be861 to
707c8ef
Compare
4 tasks
uefi/src/proto/console/gop.rs
Outdated
| @@ -533,7 +533,7 @@ pub enum BltOp<'buf> { | |||
| /// Delta must be the stride (count of bytes in a row) of the buffer. | |||
| BufferToVideo { | |||
| /// Buffer from which to copy data. | |||
| buffer: &'buf [BltPixel], | |||
| buffer: &'buf mut [BltPixel], | |||
There was a problem hiding this comment.
I'm not clear on why this buffer needs to be &mut. We're copying data from the buffer, not into it, right?
There was a problem hiding this comment.
I was misled by the underlying interface. Please recheck the new commit.
Parameter mutability was used in the wrong way. I also double-checked everything in the specification [0]. [0] https://uefi.org/specs/UEFI/2.10/24_Network_Protocols_SNP_PXE_BIS.html#efi-simple-network-nvdata
We can't use `as_mut_ptr()` as the underlying buffer is only readable. As we know the operation is only reading from the buffer, this is safe.
phip1611
force-pushed
the
bugfix-mem-gop
branch
from
707c8ef to
db43627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some memory safety issues.
Checklist