Fix legacy code, typos, suppress run_time warnings, added further support for PyVista visualisations, flagged all kernel killing code raised in Issue #46 #47
Conversation
code in the following notebooks: - notebooks/Exercise_01.ipynb - notebooks/Sec_01_Load_and_Examine.ipynb - notebooks/Sec_03_Plotting.ipynb - notebooks/Sec_04_Regridding.ipynb - notebooks/Sec_05_RegionExtraction.ipynb - notebooks/testdata_fetching.py
…window when using VSCode, flagged where kernel crashes take place.
|
|
There was a problem hiding this comment.
Thank you so much @harley-kelly! It's great for this repo to get some TLC.
The majority of these comments are to clean up any fingerprints. Once those are removed, I should probably have another look, as the outputs can make it hard to see the trees for the wood!
If there's any comments you disagree with, please do so, there's a chance I've lost some context due to the outputs etc.
notebooks/Exercise_01.ipynb
Outdated
| @@ -83,7 +82,7 @@ | |||
| }, | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": null, | |||
| "execution_count": 8, | |||
| "id": "b8eb1ce2-2160-4c3f-b97b-4b09946d84cc", | |||
| "metadata": { | |||
| "tags": [] | |||
There was a problem hiding this comment.
Github won't allow me to comment on relevant lines, but below, steps 3 and 4 are labelled the wrong way round, seems within scope of this PR.
notebooks/Sec_03_Plotting.ipynb
Outdated
There was a problem hiding this comment.
GitHub won't allow me to see this in the browser; I'll review this file later on more manually.
In the meantime, please could you double check that there's no outputs/execution numbers included?
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
Co-authored-by: Elias <[email protected]>
There was a problem hiding this comment.
Hi @harley-kelly,
Sorry for the delay on getting back to this, we've been a bit busy with sprinting.
There're still a few fingerprints here, but for the most part it seems good.
We are really grateful that you've made this contribution, and I'm concious you might not have time to keep referring back! If you do, great, that would be ideal, but if you don't and you'd like us to take over the pull request (with credit to you, of course), we'd be happy to!
| "iris.FUTURE.date_microseconds = True\n", | ||
| "\n", |
| @@ -179,8 +175,35 @@ | |||
| "outputs": [], | |||
| "source": [ | |||
| "um_cube = iris.load_cube(um_filepth,'air_temperature')\n", | |||
| "#print(um_cube)\n", | |||
| "print(um_cube.mesh)\n" | |||
| "print('You can see the data here: \\n \\n', um_cube)" | |||
There was a problem hiding this comment.
| "print('You can see the data here: \\n \\n', um_cube)" | |
| "print('You can see the data here: \n \n', um_cube)" |
| @@ -195,7 +218,7 @@ | |||
| ], | |||
| "metadata": { | |||
| "kernelspec": { | |||
| "display_name": "Python 3 (ipykernel)", | |||
| "display_name": "everyday", | |||
There was a problem hiding this comment.
| "display_name": "everyday", | |
| "display_name": "Python 3 (ipykernel)", |
| @@ -12,14 +12,18 @@ | |||
| }, | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": null, | |||
| "execution_count": 68, | |||
There was a problem hiding this comment.
| "execution_count": 68, | |
| "execution_count": null, |
| @@ -135,7 +139,7 @@ | |||
| }, | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": null, | |||
| "execution_count": 74, | |||
There was a problem hiding this comment.
| "execution_count": 74, | |
| "execution_count": null, |
| "outputs": [ | ||
| { | ||
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "[[792.0181318972558]\n", | ||
| " [26.95742764760166]\n", | ||
| " [146.36362300827432]\n", | ||
| " [166.02688348059408]\n", | ||
| " [427.4766774994878]\n", | ||
| " [263.7582442600861]]\n" | ||
| ] | ||
| } | ||
| ], |
There was a problem hiding this comment.
| "outputs": [ | |
| { | |
| "name": "stdout", | |
| "output_type": "stream", | |
| "text": [ | |
| "[[792.0181318972558]\n", | |
| " [26.95742764760166]\n", | |
| " [146.36362300827432]\n", | |
| " [166.02688348059408]\n", | |
| " [427.4766774994878]\n", | |
| " [263.7582442600861]]\n" | |
| ] | |
| } | |
| ], | |
| "outputs": [], |
There was a problem hiding this comment.
This file needs the Jupyter fingerprint removed as well!
Fix legacy code for loading data with iris. Corrected any and all typos. Added lines to suppress run_time warnings which bulk up output. Added further support for PyVista visualisations using trame. Flagged all kernel killing code raised in Issue #46 in bold red font.