Skip to content

Fix legacy code, typos, suppress run_time warnings, added further support for PyVista visualisations, flagged all kernel killing code raised in Issue #46 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 31, 2025
Merged

Fix legacy code, typos, suppress run_time warnings, added further support for PyVista visualisations, flagged all kernel killing code raised in Issue #46 #47

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6f0212e
Corrected typos, grammar and also updated legacy
harley-kelly Apr 15, 2025
98582cc
Fixed all legacy code. Added further support for PyVista interactive …
harley-kelly Apr 16, 2025
497e23e
Fix: to suppress RuntimeWarning warning flags.
harley-kelly Apr 16, 2025
cf9f5b6
Update notebooks/Exercise_01.ipynb
harley-kelly Apr 25, 2025
108e2f1
Update notebooks/Exercise_01.ipynb
harley-kelly Apr 25, 2025
cb369d2
Update notebooks/Exercise_01.ipynb
harley-kelly Apr 25, 2025
ff40113
Update notebooks/Exercise_01.ipynb
harley-kelly Apr 25, 2025
ff4d287
Update notebooks/Sec_01_Load_and_Examine.ipynb
harley-kelly Apr 25, 2025
73157cc
Update notebooks/Sec_04_Regridding.ipynb
harley-kelly Apr 25, 2025
cb45c42
Update notebooks/Sec_04_Regridding.ipynb
harley-kelly Apr 25, 2025
0e6df72
Update notebooks/Sec_04_Regridding.ipynb
harley-kelly Apr 25, 2025
cf41c15
Update notebooks/Sec_04_Regridding.ipynb
harley-kelly Apr 25, 2025
2315033
Update notebooks/Sec_01_Load_and_Examine.ipynb
harley-kelly Apr 25, 2025
2a301b8
Update notebooks/Sec_01_Load_and_Examine.ipynb
harley-kelly Apr 25, 2025
c993893
Apply suggestions from code review
harley-kelly Apr 25, 2025
2da09be
Apply suggestions from code review
harley-kelly Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions notebooks/Exercise_01.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,10 @@
"import geovista as gv\n",
"import geovista.theme\n",
"import iris.quickplot as qplt\n",
"import iris\n",
"import iris \n",
"from geovista import GeoPlotter\n",
"from esmf_regrid.experimental.unstructured_scheme import MeshToGridESMFRegridder, GridToMeshESMFRegridder\n",
"from iris.experimental.ugrid.load import PARSE_UGRID_ON_LOAD\n",
"pv.rcParams[\"use_ipyvtk\"] = True\n",
"# pv.rcParams[\"use_ipyvtk\"] = True\n",
"iris.FUTURE.datum_support = True # avoids some warnings"
]
},
Expand All @@ -64,7 +63,7 @@
},
{
"cell_type": "code",
"execution_count": null,
"execution_count": 7,
"id": "1cd00d6a-e10a-4af1-870d-1874cead45c2",
"metadata": {},
"outputs": [],
Expand All @@ -83,7 +82,7 @@
},
{
"cell_type": "code",
"execution_count": null,
"execution_count": 8,
"id": "b8eb1ce2-2160-4c3f-b97b-4b09946d84cc",
"metadata": {
"tags": []
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github won't allow me to comment on relevant lines, but below, steps 3 and 4 are labelled the wrong way round, seems within scope of this PR.

Expand Down Expand Up @@ -275,7 +274,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"display_name": "everyday",
"language": "python",
"name": "python3"
},
Expand All @@ -289,7 +288,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.9.16"
"version": "3.13.2"
},
"toc-autonumbering": true,
"toc-showtags": false
Expand Down
Loading