Batch tutorial: create placements directly - #332
Open
vangberg wants to merge 1 commit into
Open
Conversation
This was referenced Aug 27, 2026
vangberg
commented
Aug 28, 2026
| rank: species | ||
| status: 20 # ICNP | ||
|
|
||
| nanobdellaceae: |
Contributor
Author
There was a problem hiding this comment.
I feel some tension between using fixtures with names that describe the fixture (e.g. valid_name or unpublished_name) and then just using the name like here. Not sure what direction to go in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the batch tutorial predates the
Placementclass. Currently it creates placements implicitly by settingName#parentandName#incertae_sedis, which then creates placements viaName#ensure_consistent_placementwhich is invoked as anafter_savehook.In preparation for #173 I have refactored the batch tutorial to create placements directly and added a bunch of tests verifying current behavior.