Implement SampleCmpBias and SampleCmpGrad #8931
Conversation
davli-nv
force-pushed
the
feature/sample-cmp
branch
from
c89bffb to
2e5adbe
Compare
davli-nv
force-pushed
the
feature/sample-cmp
branch
from
2e5adbe to
55e4727
Compare
-these are new for HLSL shader model 6.8 -also change glsl.meta.slang to use existing sampler typealias in hlsl.meta.slang fixes #8929
davli-nv
force-pushed
the
feature/sample-cmp
branch
from
55e4727 to
ef9b27e
Compare
jkwak-work
left a comment
jkwak-work
left a comment
There was a problem hiding this comment.
Looks good to me.
But ... can you also address TODO-s in glsl.meta.slang that seems to be related?
There are more than one location in glsl.meta.slang with the following comment:
// TODO: Need to apply bias
Here is one of the examples,
slang/source/slang/glsl.meta.slang
Lines 2005 to 2006 in d9b92cc
When I was writing the GLSL functions, there was no way to apply bias in HLSL.
The functions in glsl.meta.slang should simply call the counter part functions in hlsl.meta.slang that can take bias value.
|
Thanks @jkwak-work, I filed #9038 for the GLSL work since GLSL is lower priority compared to my other tasks. |
| float SampleCmpGrad(vector<float, Shape.dimensions+isArray> location, float compareValue, vector<float, Shape.dimensions> gradX, vector<float, Shape.dimensions> gradY, constexpr vector<int, Shape.planeDimensions> offset) | ||
| { | ||
| static_assert(!(Shape is __ShapeCube), "SampleCmpGrad with offset is not supported for TextureCube or TextureCubeArray"); | ||
| static_assert(!(Shape is __ShapeCube && isArray != 0), "SampleCmpGrad is not supported for TextureCubeArray"); |
There was a problem hiding this comment.
Is the second assert redundant? The first one will always fire first
There was a problem hiding this comment.
Good point, I'll move the stricter assert first, I think both should be kept
these are new for HLSL shader model 6.8
fixes #8929